From: Jens Axboe <axboe@kernel.dk>
To: Josef Bacik <josef@toxicpanda.com>,
nbd-general@lists.sourceforge.net, linux-block@vger.kernel.org,
kernel-team@fb.com
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] nbd: don't set the device size until we're connected
Date: Mon, 9 Oct 2017 12:29:41 -0600 [thread overview]
Message-ID: <29df4da4-fb2d-3e34-95e0-412913de2091@kernel.dk> (raw)
In-Reply-To: <1507569130-5067-1-git-send-email-jbacik@fb.com>
On 10/09/2017 11:12 AM, Josef Bacik wrote:
> A user reported a regression with using the normal ioctl interface on
> newer kernels. This happens because I was setting the device size
> before the device was actually connected, which caused us to error out
> and close everything down. This didn't happen on netlink because we
> hold the device lock the whole time we're setting things up, but we
> don't do that for the ioctl path. This fixes the problem.
Applied, thanks Josef.
--
Jens Axboe
prev parent reply other threads:[~2017-10-09 18:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 17:12 [PATCH] nbd: don't set the device size until we're connected Josef Bacik
2017-10-09 18:29 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29df4da4-fb2d-3e34-95e0-412913de2091@kernel.dk \
--to=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=nbd-general@lists.sourceforge.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox