From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Bean Huo <huobean@gmail.com>
Cc: Bean Huo <beanhuo@micron.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: Use REQ_OP_WRITE instead of its integer constant 1 in op_is_write()
Date: Tue, 16 Nov 2021 01:30:11 +0000 [thread overview]
Message-ID: <2a239998-2bab-c1ad-dcb9-6e51c8a5d05f@nvidia.com> (raw)
In-Reply-To: <20211115215819.28787-1-huobean@gmail.com>
Bean,
> static inline bool op_is_write(unsigned int op)
> {
> - return (op & 1);
> + return (op & REQ_OP_WRITE);
> }
As pointed out by Damien it supposed to indicate data out and not
only write request REQ_OP_WRITE.
>
> /*
> --
> 2.25.1
>
prev parent reply other threads:[~2021-11-16 1:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 21:58 [PATCH] block: Use REQ_OP_WRITE instead of its integer constant 1 in op_is_write() Bean Huo
2021-11-15 23:48 ` Damien Le Moal
2021-11-16 2:38 ` Keith Busch
2021-11-16 1:30 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a239998-2bab-c1ad-dcb9-6e51c8a5d05f@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=beanhuo@micron.com \
--cc=huobean@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox