From: Jens Axboe <axboe@kernel.dk>
To: Yu Kuai <yukuai3@huawei.com>,
andriy.shevchenko@linux.intel.com, john.garry@huawei.com,
ming.lei@redhat.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com
Subject: Re: [PATCH -next RFC 2/6] block: refactor to split bio thoroughly
Date: Tue, 29 Mar 2022 06:46:35 -0600 [thread overview]
Message-ID: <2b37ce73-83dd-e572-9578-7bb045f1040b@kernel.dk> (raw)
In-Reply-To: <20220329094048.2107094-3-yukuai3@huawei.com>
On 3/29/22 3:40 AM, Yu Kuai wrote:
> Currently, the splited bio is handled first, and then continue to split
> the original bio. This patch tries to split the original bio thoroughly,
> so that it can be known in advance how many tags will be needed.
This makes the bio almost 10% bigger in size, which is NOT something
that is just done casually and without strong reasoning.
So please provide that, your commit message is completely missing
justification for why this change is useful or necessary. A good
commit always explains WHY the change needs to be made, yours is
simply stating WHAT is being done. The latter can be gleaned from
the code change anyway.
--
Jens Axboe
next prev parent reply other threads:[~2022-03-29 12:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 9:40 [PATCH -next RFC 0/6] improve large random io for HDD Yu Kuai
2022-03-29 9:40 ` [PATCH -next RFC 1/6] blk-mq: add a new flag 'BLK_MQ_F_NO_TAG_PREEMPTION' Yu Kuai
2022-03-29 12:44 ` Jens Axboe
2022-03-30 1:18 ` yukuai (C)
2022-03-30 1:20 ` Jens Axboe
2022-03-29 9:40 ` [PATCH -next RFC 2/6] block: refactor to split bio thoroughly Yu Kuai
2022-03-29 12:46 ` Jens Axboe [this message]
2022-03-30 1:35 ` yukuai (C)
2022-03-29 13:32 ` Christoph Hellwig
2022-03-29 14:35 ` Jens Axboe
2022-03-29 14:40 ` Christoph Hellwig
2022-03-29 14:41 ` Jens Axboe
2022-03-29 14:42 ` Christoph Hellwig
2022-03-30 1:54 ` yukuai (C)
2022-03-29 9:40 ` [PATCH -next RFC 3/6] blk-mq: record how many tags are needed for splited bio Yu Kuai
2022-03-29 9:40 ` [PATCH -next RFC 4/6] sbitmap: wake up the number of threads based on required tags Yu Kuai
2022-03-29 9:40 ` [PATCH -next RFC 5/6] blk-mq: don't preempt tag expect for split bios Yu Kuai
2022-03-29 9:40 ` [PATCH -next RFC 6/6] sbitmap: force tag preemption if free tags are sufficient Yu Kuai
2022-03-29 12:53 ` [PATCH -next RFC 0/6] improve large random io for HDD Jens Axboe
2022-03-30 2:05 ` yukuai (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b37ce73-83dd-e572-9578-7bb045f1040b@kernel.dk \
--to=axboe@kernel.dk \
--cc=andriy.shevchenko@linux.intel.com \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox