From: Damien Le Moal <dlemoal@kernel.org>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
linux-btrace@vger.kernel.org
Subject: Re: [PATCH v2 03/11] blktrace: add option to request a specific trace protocol version
Date: Mon, 20 Jul 2026 20:52:33 +0900 [thread overview]
Message-ID: <2ba7a6fd-895b-468f-ab33-67dfd8803451@kernel.org> (raw)
In-Reply-To: <20260720111417.1658507-4-johannes.thumshirn@wdc.com>
On 7/20/26 20:14, Johannes Thumshirn wrote:
> Add the '--trace-version=<1|2>' command line option to select the trace
> protocol version requested from the kernel. Requesting version 1 forces
> blktrace to use the old BLKTRACESETUP ioctl, while version 2 (the
> default) uses BLKTRACESETUP2.
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Looks OK to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-07-20 11:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 11:14 [PATCH v2 00/11] blktrace: parse blk_io_trace2 in btt and iowatcher Johannes Thumshirn
2026-07-20 11:14 ` [PATCH v2 01/11] btt: use blk_io_trace2 internally Johannes Thumshirn
2026-07-20 11:14 ` [PATCH v2 02/11] btt: natively parse blk_io_trace2 Johannes Thumshirn
2026-07-20 11:14 ` [PATCH v2 03/11] blktrace: add option to request a specific trace protocol version Johannes Thumshirn
2026-07-20 11:52 ` Damien Le Moal [this message]
2026-07-20 11:14 ` [PATCH v2 04/11] blkrawverify: use blk_io_trace2 internally Johannes Thumshirn
2026-07-20 11:14 ` [PATCH v2 05/11] blkrawverify: natively parse blk_io_trace2 Johannes Thumshirn
2026-07-20 11:14 ` [PATCH v2 06/11] blkiomon: use blk_io_trace2 internally Johannes Thumshirn
2026-07-20 11:14 ` [PATCH v2 07/11] blkiomon: natively parse blk_io_trace2 Johannes Thumshirn
2026-07-20 11:14 ` [PATCH v2 08/11] iowatcher: use blk_io_trace2 internally Johannes Thumshirn
2026-07-20 11:14 ` [PATCH v2 09/11] iowatcher: natively parse blk_io_trace2 Johannes Thumshirn
2026-07-20 11:14 ` [PATCH v2 10/11] btreplay: support blk_io_trace2 in btrecord Johannes Thumshirn
2026-07-20 11:14 ` [PATCH v2 11/11] blkparse: add option to emit a specific trace protocol version Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ba7a6fd-895b-468f-ab33-67dfd8803451@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrace@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox