Re: please revert the UFS HPB support

Christoph Hellwig
2021-10-21T15:15:43Z

On Thu, Oct 21, 2021 at 09:13:30AM -0600, Jens Axboe wrote:
> On 10/21/21 8:42 AM, Christoph Hellwig wrote:
> > Hi Martin,
> >
> > I just noticed the UFS HPB support landed in 5.15, and just as
> > before it is completely broken by allocating another request on
> > the same device and then reinserting it in the queue. It is bad
> > enough that we have to live with blk_insert_cloned_request for
> > dm-mpath, but this is too big of an API abuse to make it into
> > a release. We need to drop this code ASAP, and I can prepare
> > a patch for that.
>
> That sounds awful, do you have a link to the offending commit(s)?

I'll need to look for it, busy in calls right now, but just grep for
blk_insert_cloned_request.