Re: please revert the UFS HPB support

Christoph Hellwig
2021-10-23T04:40:39Z

On Fri, Oct 22, 2021 at 09:54:44PM -0400, Martin K. Petersen wrote:
> The series went through 40 iterations on the list prior to being merged.
> I don't recall a better approach to reconcile the HPB model with the
> stack being offered during that process?
>
> As much as I don't like HPB, all the major UFS subsystem stakeholders
> are behind it. The hardware is shipping and various device stacks
> already adopted support for it. At this stage I don't think dropping the
> code is a way forward. I am much more in favor of having a productive
> discussion about how to go about addressing the problems with the
> queuing model...

This is іs not about HPB about a feature beeing a bad idea. I explained
that at least a dozend times, and there's been no sensible counter
arguments to that but it has been merged anyway. (FYI Zoned devices
are the obvious and old answer).

But this implementation is simply completely broken from the block
layer POV and we must not release a kernel with that brokenness in it.