From: Damien Le Moal <dlemoal@kernel.org>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH 5/5] block: switch ldm partition code to use pr_xxx() functions
Date: Tue, 15 Aug 2023 21:41:42 +0900 [thread overview]
Message-ID: <2d1bc374-cb98-8986-75b3-230d1ac580f9@kernel.org> (raw)
In-Reply-To: <790b86db-da57-4997-86f4-98796bcca8b1@wdc.com>
On 8/15/23 19:06, Johannes Thumshirn wrote:
> On 08.08.23 19:56, Damien Le Moal wrote:
>> +#define ldm_debug(f, a...) pr_debug("%s(): " f, __func__, ##a) +#define
>> ldm_crit(f, a...) pr_crit("%s(): " f, __func__, ##a) +#define
>> ldm_error(f, a...) pr_err("%s(): " f, __func__, ##a) +#define
>> ldm_info(f, a...) pr_info("%s(): " f, __func__, ##a)
>
> Is there any value in keeping these ldm_XXX() macros around, other than
> printing the function name?
You named it: I didn't want to change the messages.
I do not mind simplifying these by removing the function name, but if we do not,
then the macros actually simplify the print calls.
>
> I'd just get rid of them as well and replace with the according pr_XXX()
> calls.
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2023-08-15 12:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 13:56 [PATCH 0/5] Some minor cleanups Damien Le Moal
2023-08-08 13:56 ` [PATCH 1/5] block: use PAGE_SECTORS_SHIFT to set limits Damien Le Moal
2023-08-09 2:04 ` Chaitanya Kulkarni
2023-08-09 6:07 ` Hannes Reinecke
2023-08-15 10:00 ` Johannes Thumshirn
2023-08-08 13:56 ` [PATCH 2/5] block: use pr_xxx() instead of printk() Damien Le Moal
2023-08-09 2:06 ` Chaitanya Kulkarni
2023-08-09 6:08 ` Hannes Reinecke
2023-08-15 10:01 ` Johannes Thumshirn
2023-08-08 13:57 ` [PATCH 3/5] block: use pr_xxx() instead of printk() in partition code Damien Le Moal
2023-08-09 2:07 ` Chaitanya Kulkarni
2023-08-09 3:42 ` Damien Le Moal
2023-08-09 6:09 ` Hannes Reinecke
2023-08-15 10:02 ` Johannes Thumshirn
2023-08-08 13:57 ` [PATCH 4/5] block: Improve efi partition debug messages Damien Le Moal
2023-08-09 2:07 ` Chaitanya Kulkarni
2023-08-09 6:09 ` Hannes Reinecke
2023-08-15 10:03 ` Johannes Thumshirn
2023-08-08 13:57 ` [PATCH 5/5] block: switch ldm partition code to use pr_xxx() functions Damien Le Moal
2023-08-09 2:08 ` Chaitanya Kulkarni
2023-08-09 6:10 ` Hannes Reinecke
2023-08-15 10:06 ` Johannes Thumshirn
2023-08-15 12:41 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d1bc374-cb98-8986-75b3-230d1ac580f9@kernel.org \
--to=dlemoal@kernel.org \
--cc=Johannes.Thumshirn@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox