From: Hristo Venev <hristo@venev.name>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] io_uring: allocate the two rings together
Date: Tue, 27 Aug 2019 20:35:49 +0100 [thread overview]
Message-ID: <2f409a14ea27516a97cb7a7f1d70de7fe45c7c69.camel@venev.name> (raw)
In-Reply-To: <80e0e408-f602-4446-d244-60f9d4ce9c71@kernel.dk>
[-- Attachment #1: Type: text/plain, Size: 495 bytes --]
Sorry for the duplicate reply, I forgot to CC the mailing list.
On Tue, 2019-08-27 at 09:50 -0600, Jens Axboe wrote:
> Outside of going for a cleanup, have you observed any wins from this
> change?
I haven't ran any interesting benchmarks. The cp examples in liburing
are running as fast as before, at least on x86_64.
Do you think it makes sense to tell userspace that the sq and cq mmap
offsets now mean the same thing? We could add a flag set by the kernel
to io_uring_params.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-08-27 19:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 17:23 [PATCH] io_uring: allocate the two rings together Hristo Venev
2019-08-27 15:50 ` Jens Axboe
2019-08-27 19:35 ` Hristo Venev [this message]
2019-08-29 15:04 ` Jens Axboe
2019-09-06 16:26 ` Jens Axboe
2019-09-06 19:12 ` [PATCH 1/2] liburing/test: There are now 4 reserved fields Hristo Venev
2019-09-06 19:12 ` [PATCH 2/2] liburing: Use the single mmap feature Hristo Venev
2019-09-06 19:30 ` Jens Axboe
2019-09-06 19:24 ` [PATCH 1/2] liburing/test: There are now 4 reserved fields Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f409a14ea27516a97cb7a7f1d70de7fe45c7c69.camel@venev.name \
--to=hristo@venev.name \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox