Linux block layer
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: retry blk_rq_map_user_iov() on failure
Date: Thu, 31 Oct 2019 19:35:37 -0600	[thread overview]
Message-ID: <306b4114-7509-bdad-d78e-8048615223da@kernel.dk> (raw)
In-Reply-To: <fec5226c-d13b-a7ef-cb3a-217b26a1aa22@kernel.dk>

On 10/31/19 1:30 PM, Jens Axboe wrote:
> On 10/31/19 1:26 PM, Jens Axboe wrote:
>> We ran into an issue in production where reading an NVMe drive log
>> randomly fails. The request is a big one, 1056K, and the application
>> (nvme-cli) nicely aligns the buffer. This means the kernel will attempt
>> to map the pages in for zero-copy DMA, but we ultimately fail adding
>> enough pages to the request to satisfy the size requirement as we ran
>> out of segments supported by the hardware.
>>
>> If we fail a user map that attempts to map pages in directly, retry with
>> copy == true set.
>>
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> 
> I did actually add comments to this, but apparently sent out the version
> without comments... Current one below, only difference is the addition
> of the comment explaining why we retry.

Disregard this - I had a patch to make bio_copy_user_iov() handle strings
of bios that this would also need, it's not enough by itself.

-- 
Jens Axboe


      reply	other threads:[~2019-11-01  1:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31 19:26 [PATCH] block: retry blk_rq_map_user_iov() on failure Jens Axboe
2019-10-31 19:30 ` Jens Axboe
2019-11-01  1:35   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=306b4114-7509-bdad-d78e-8048615223da@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox