public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <Bart.VanAssche@wdc.com>, "hch@lst.de" <hch@lst.de>
Cc: "jiufei.xue@linux.alibaba.com" <jiufei.xue@linux.alibaba.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH v2] block: bio_check_eod() needs to consider partition
Date: Tue, 13 Mar 2018 10:37:05 -0700	[thread overview]
Message-ID: <315d98a1-7ade-4d8c-a71d-7716d27413ac@kernel.dk> (raw)
In-Reply-To: <1520958339.2638.8.camel@wdc.com>

On 3/13/18 9:25 AM, Bart Van Assche wrote:
> On Tue, 2018-03-13 at 07:49 -0700, Jens Axboe wrote:
>> On 3/13/18 2:18 AM, Christoph Hellwig wrote:
>>> bio_check_eod() should check partiton size not the whole disk if
>>> bio->bi_partno is non-zero.  Does this by taking the call to bio_check_eod
>>> into blk_partition_remap.
>>
>> Applied, thanks.
> 
> Hello Christoph and Jens,
> 
> I think that this patch introduces a severe regression: with this patch applied
> a VM that I use for kernel testing doesn't boot anymore. If I revert this patch
> that VM boots fine again. This is what I see on the serial console with this
> patch applied:
> 
> virtio_blk virtio4: [vda] 41943040 512-byte logical blocks (21.5 GB/20.0 GiB)
>  vda: vda1
> attempt to access beyond end of device
> vda: rw=0, want=41940872, limit=41938944
> attempt to access beyond end of device
> vda: rw=0, want=41940872, limit=41938944

I've killed the patch for now, thanks for the quick test, Bart.

-- 
Jens Axboe

  parent reply	other threads:[~2018-03-13 17:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13  9:18 [PATCH v2] block: bio_check_eod() needs to consider partition Christoph Hellwig
2018-03-13 14:49 ` Jens Axboe
2018-03-13 16:25   ` Bart Van Assche
2018-03-13 16:36     ` hch
2018-03-13 17:37     ` Jens Axboe [this message]
2018-03-14 13:03     ` hch
2018-03-14 15:08       ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=315d98a1-7ade-4d8c-a71d-7716d27413ac@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=Bart.VanAssche@wdc.com \
    --cc=hch@lst.de \
    --cc=jiufei.xue@linux.alibaba.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox