From: Davidlohr Bueso <dave@stgolabs.net>
To: Vincent Mailhol <mailhol@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-efi@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] block: store GPT attributes as a raw value
Date: Thu, 10 Sep 2026 10:30:50 -0700 [thread overview]
Message-ID: <3205907d756584ad1c5c7129aa126433@stgolabs.net> (raw)
In-Reply-To: <20260908-fix_gpt_entry_attributes-v1-1-a4dcb417e8fc@kernel.org>
On 2026-09-08 11:58, Vincent Mailhol wrote:
> struct _gpt_entry_attributes currently models the GPT partition entry
> attributes field with bitfields. This is broken on machines using the
> __BIG_ENDIAN_BITFIELD ABI because GPT always stores the attributes on
> disk as a 64-bit little-endian.
>
> No current code consumes individual fields from that structure. So just
> remove struct _gpt_entry_attributes entirely and replace it by an
> __le64
> value in struct _gpt_entry instead. This lets users apply endian-aware
> masks explicitly when inspecting attribute bits.
>
> Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
Acked-by: Davidlohr Bueso <dave@stgolabs.net>
next prev parent reply other threads:[~2026-09-10 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 18:58 [PATCH RESEND] block: store GPT attributes as a raw value Vincent Mailhol
2026-09-10 7:16 ` Christoph Hellwig
2026-09-10 17:30 ` Davidlohr Bueso [this message]
2026-09-10 20:55 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3205907d756584ad1c5c7129aa126433@stgolabs.net \
--to=dave@stgolabs.net \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox