From: Jens Axboe <axboe@kernel.dk>
To: Caizhiyong <caizhiyong@hisilicon.com>, Wang YanQing <udknight@gmail.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"pombredanne@nexb.com" <pombredanne@nexb.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jiangheng <jiangheng@hisilicon.com>
Subject: Re: [PATCH] block: add verifier for cmdline partition
Date: Fri, 4 May 2018 08:20:08 -0600 [thread overview]
Message-ID: <3267b3ec-0500-5772-949e-49570395085d@kernel.dk> (raw)
In-Reply-To: <C3050A4DBA34F345975765E43127F10F8B77159A@dggemm511-mbs.china.huawei.com>
On 5/4/18 1:07 AM, Caizhiyong wrote:
>> -----Original Message-----
>> From: Wang YanQing [mailto:udknight@gmail.com]
>> Sent: Thursday, May 03, 2018 7:18 PM
>> To: axboe@kernel.dk
>> Cc: gregkh@linuxfoundation.org; pombredanne@nexb.com;
>> tglx@linutronix.de; Caizhiyong <caizhiyong@hisilicon.com>; linux-
>> block@vger.kernel.org; linux-kernel@vger.kernel.org
>> Subject: [PATCH] block: add verifier for cmdline partition
>>
>> I meet strange filesystem corruption issue recently, the reason
>> is there are overlaps partitions in cmdline partition argument.
>>
>> This patch add verifier for cmdline partition, then if there are
>> overlaps partitions, cmdline_partition will return error and log
>> a error message.
>>
>
> Partition overlap was intentionally designed in this cmdline partition.
> some time, the cmdline partition save raw data(not filesystem), the overlap makes data access very convenient.
>
> reference http://lists.infradead.org/pipermail/linux-mtd/2013-August/048092.html
Might make sense to warn about it at least, it can be very surprising if
it happens inadvertently.
--
Jens Axboe
prev parent reply other threads:[~2018-05-04 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 11:17 [PATCH] block: add verifier for cmdline partition Wang YanQing
2018-05-04 7:07 ` Caizhiyong
2018-05-04 14:20 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3267b3ec-0500-5772-949e-49570395085d@kernel.dk \
--to=axboe@kernel.dk \
--cc=caizhiyong@hisilicon.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiangheng@hisilicon.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox