From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D078CC001DB for ; Fri, 4 Aug 2023 17:31:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232301AbjHDRb6 (ORCPT ); Fri, 4 Aug 2023 13:31:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231142AbjHDRb6 (ORCPT ); Fri, 4 Aug 2023 13:31:58 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA4F13C25 for ; Fri, 4 Aug 2023 10:31:56 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1bb91c20602so4503215ad.0 for ; Fri, 04 Aug 2023 10:31:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1691170316; x=1691775116; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0qQmF/aDPN/Nd1iFTYAKf0iaoJAfdocEV/pAQRYwbqs=; b=Ok9lyphivxgObFBlVcatBdf9FmrWhag5FrhV0znfPx7b0uGvx81YG9TIoMjLRNS7b/ ts0mtR1Y9E0+QBeAk/a0+IlNVPt+PxsQChz4M88beydb3Mpsg7rhIdCllLO6JQb6IBTV Y4Ku4AtHVmGXtReS5HYAymdGGt4hwG6JyKtnjSbpeF7/eoxKNvLxy0f0PbDgukuFafYp zgiXrx2mpc+A684TIxjc2aQBX5g7EVb4AiL+aX8VXtRaB71gh5dh0d2MzDsHgoigdu9u vQd6ZSCf++eWeBf7rkJ/u0bayfu60/INm38m5w3FLO/qPHjtZRa54bcrOKhB9ga/smdb U+qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691170316; x=1691775116; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0qQmF/aDPN/Nd1iFTYAKf0iaoJAfdocEV/pAQRYwbqs=; b=NXXSiZ6IqyUuCARvFjB1Aom30E+FV9L8otBvM6mQkzL0ZX7XXtKOk9IfDNOici/647 oOhgQRYHxE/JcFcrOEKl7GS/k4xVjKMab6qbweVBHPfJuMCotSlrCFE5FczUnXKkn24V jQBxK4AZluOo39Mod2vC9vwZp6eLefPsFDGv0cr5h8/dXtFVteI9+HX7xvu5goXqIcmR aCKDZCXeUG8JOuY9DRRV+ecLnbMaBFgPQesZ9pQU3bxmD0Qf56XzRF4ZTx+R7eG9aZv7 NBZWYh26+3O6WahP1JhyfkACbMisPe0YzHcP7Zk9W38+6gkcx9upVVmisW1BZxJ3zigr 8ttA== X-Gm-Message-State: ABy/qLaXoSKpRLNcZRrcggUNN0/WkMEfAlzcfALBDWxWeX0pZ+Qgajid yAJeTJ5cC1qEWSezKSV7VOpNDPmz3lnEhYYVDbg= X-Google-Smtp-Source: APBJJlEdzXnBEVkC+oRckNCewl432/bLmEhe9+Wm62NxjTqEJ4fFwsHGLSLh75I/cZUN4QFCJqB/nA== X-Received: by 2002:a17:903:244f:b0:1b3:ec39:f42c with SMTP id l15-20020a170903244f00b001b3ec39f42cmr24213518pls.5.1691170316247; Fri, 04 Aug 2023 10:31:56 -0700 (PDT) Received: from [172.20.1.218] (071-095-160-189.biz.spectrum.com. [71.95.160.189]) by smtp.gmail.com with ESMTPSA id ju2-20020a170903428200b001bbcf43e120sm2024602plb.95.2023.08.04.10.31.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Aug 2023 10:31:54 -0700 (PDT) Message-ID: <32b8aef9-061a-bf4b-e3a4-c72a4ecbe27f@kernel.dk> Date: Fri, 4 Aug 2023 11:31:51 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH] romfs: only select BUFFER_HEAD for the block based path Content-Language: en-US To: Christoph Hellwig Cc: lizetao1@huawei.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig References: <20230804102648.78683-1-hch@infradead.org> From: Jens Axboe In-Reply-To: <20230804102648.78683-1-hch@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 8/4/23 4:26?AM, Christoph Hellwig wrote: > selecting BUFFER_HEAD unconditionally does not work as romfs can also > be built with only the MTD backend and thus without CONFIG_BLOCK. I folded this in with the other one and made a note about that. -- Jens Axboe