From: Jens Axboe <axboe@fb.com>
To: Shaohua Li <shli@fb.com>, Christoph Hellwig <hch@infradead.org>
Cc: <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<Kernel-team@fb.com>
Subject: Re: [PATCH V2 2/2] blk-mq: immediately dispatch big size request
Date: Thu, 3 Nov 2016 22:00:58 -0600 [thread overview]
Message-ID: <32bef0f6-c194-e31e-3a85-5aa21a6e81a4@fb.com> (raw)
In-Reply-To: <20161104001353.GA58908@omida-mbp.local.dhcp.thefacebook.com>
On 11/03/2016 06:13 PM, Shaohua Li wrote:
> On Thu, Nov 03, 2016 at 05:09:54PM -0700, Christoph Hellwig wrote:
>> On Thu, Nov 03, 2016 at 05:03:54PM -0700, Shaohua Li wrote:
>>> This is corresponding part for blk-mq. Disk with multiple hardware
>>> queues doesn't need this as we only hold 1 request at most.
>>
>> Any reason you only do this for the SQ and not the MQ case?
>
> Right above:
> Disk with multiple hardware queues doesn't need this as we only hold 1
> request at most.
I've applied 1-2 for 4.10, but we probably should look into unifying
those parts of sq and mq in general. For instance, it doesn't seem to
make a lot of sense why we'd depth limit sq and not mq.
--
Jens Axboe
next prev parent reply other threads:[~2016-11-04 4:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 0:03 [PATCH V2 1/2] block: immediately dispatch big size request Shaohua Li
2016-11-04 0:03 ` [PATCH V2 2/2] blk-mq: " Shaohua Li
2016-11-04 0:09 ` Christoph Hellwig
2016-11-04 0:13 ` Shaohua Li
2016-11-04 4:00 ` Jens Axboe [this message]
[not found] ` <20161104144614.GA18373@infradead.org>
2016-11-04 15:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32bef0f6-c194-e31e-3a85-5aa21a6e81a4@fb.com \
--to=axboe@fb.com \
--cc=Kernel-team@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox