From: Bart Van Assche <bvanassche@acm.org>
To: lipeifeng@oppo.com, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
zhangshiming@oppo.com, guojian@oppo.com
Subject: Re: [PATCH] block: mq-deadline: rename sort_list to sort_rb
Date: Tue, 4 Jul 2023 07:13:17 -0700 [thread overview]
Message-ID: <32dad510-1508-f0dc-ab49-60d56ed2c2d6@acm.org> (raw)
In-Reply-To: <20230704040626.24899-1-lipeifeng@oppo.com>
On 7/3/23 21:06, lipeifeng@oppo.com wrote:
> Mq-deadline would store request in list:fifo_list and
> rb_tree:sort_list, and sort_list should be renamed to
> sort_rb which is beneficial for understanding.
Huh? I think this patch makes the code less readable instead of more
readable ...
Bart.
next prev parent reply other threads:[~2023-07-04 14:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 4:06 [PATCH] block: mq-deadline: rename sort_list to sort_rb lipeifeng
2023-07-04 14:13 ` Bart Van Assche [this message]
2023-07-05 0:30 ` 回复: " 李培锋(wink)
2023-07-06 9:27 ` 李培锋(wink)
2023-07-06 14:05 ` Jens Axboe
2023-07-07 0:26 ` 回复: " 李培锋(wink)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32dad510-1508-f0dc-ab49-60d56ed2c2d6@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=guojian@oppo.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeifeng@oppo.com \
--cc=zhangshiming@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox