From: Tianxianting <tian.xianting@h3c.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] [v2] blk-mq: use BLK_MQ_NO_TAG for no tag
Date: Wed, 26 Aug 2020 06:02:57 +0000 [thread overview]
Message-ID: <3321aa16ad214cb1a0a5cda1309f0e45@h3c.com> (raw)
In-Reply-To: <20200826042918.GA116347@T590>
Hi Ming Lei
Thanks for your quick comment.
As the function request_to_qc_t() in 'include/linux/blk-mq.h ' used the magic '-1',
Seems it is hard to replace it with BLK_MQ_NO_TAG :(
-----Original Message-----
From: Ming Lei [mailto:ming.lei@redhat.com]
Sent: Wednesday, August 26, 2020 12:29 PM
To: tianxianting (RD) <tian.xianting@h3c.com>
Cc: axboe@kernel.dk; linux-block@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] blk-mq: use BLK_MQ_NO_TAG for no tag
On Wed, Aug 26, 2020 at 10:06:51AM +0800, Xianting Tian wrote:
> Replace various magic -1 constants for tags with BLK_MQ_NO_TAG.
> And move the definition of BLK_MQ_NO_TAG from 'block/blk-mq-tag.h'
> to 'include/linux/blk-mq.h'
All three symbols are supposed for block core internal code only, so looks you shouldn't move them to public header.
Thanks,
Ming
prev parent reply other threads:[~2020-08-26 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 2:06 [PATCH] [v2] blk-mq: use BLK_MQ_NO_TAG for no tag Xianting Tian
2020-08-26 4:29 ` Ming Lei
2020-08-26 6:02 ` Tianxianting [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3321aa16ad214cb1a0a5cda1309f0e45@h3c.com \
--to=tian.xianting@h3c.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).