From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <tom.leiming@gmail.com>, Josef Bacik <josef@toxicpanda.com>
Cc: Ming Lei <ming.lei@redhat.com>, Josef Bacik <jbacik@fb.com>,
linux-block <linux-block@vger.kernel.org>
Subject: Re: [Bug] block/for-next: IO hang in rq_qos_throttle
Date: Sat, 28 Jul 2018 09:08:02 -0600 [thread overview]
Message-ID: <33dfb9ff-85da-24a6-a17d-1a4dedb589e0@kernel.dk> (raw)
In-Reply-To: <CACVXFVOuaCT6Q04ztFubLAZUhPPXjpCdDNckoRquN1jvtb8eZw@mail.gmail.com>
On 7/28/18 6:11 AM, Ming Lei wrote:
> On Fri, Jul 27, 2018 at 11:47 PM, Josef Bacik <josef@toxicpanda.com> wrote:
>> On Sun, Jul 22, 2018 at 03:28:05PM +0800, Ming Lei wrote:
>>> On Sun, Jul 22, 2018 at 02:15:38AM +0000, Josef Bacik wrote:
>>>> Yup I sent a patch for this on Thursday, sorry about that,
>>>>
>>>
>>> I just applied the patch of 'blk-rq-qos: make depth comparisons unsigned',
>>> looks the same IO hang can be triggered too.
>>
>> Ok I'm back from vacation and I'm trying to reproduce but it's not happening for
>> me. What testing infrastructure is this? blktests and xfstests don't have a
>> sanity/ in their test suites. I'm wondering if there's something else about the
>> test that I'm missing. Thanks,
>
> As I mentioned,
>
> The following IO hang is triggered on dbench test on xfs/usb-storage:
>
> dbench -t 20 -s 64
Josef, the key here is likely a queue depth of 1. So if you're running on
sata, then just limit the device depth to 1.
--
Jens Axboe
next prev parent reply other threads:[~2018-07-28 15:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-21 23:22 [Bug] block/for-next: IO hang in rq_qos_throttle Ming Lei
2018-07-22 2:15 ` Josef Bacik
2018-07-22 7:28 ` Ming Lei
2018-07-22 12:24 ` Josef Bacik
2018-07-27 15:47 ` Josef Bacik
2018-07-28 12:11 ` Ming Lei
2018-07-28 15:08 ` Jens Axboe [this message]
2018-07-31 16:41 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33dfb9ff-85da-24a6-a17d-1a4dedb589e0@kernel.dk \
--to=axboe@kernel.dk \
--cc=jbacik@fb.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox