From: Hannes Reinecke <hare@suse.de>
To: Damien Le Moal <dlemoal@kernel.org>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v11 06/13] zloop: fix ordered zone append handling
Date: Thu, 19 Nov 2026 08:19:00 +0100 [thread overview]
Message-ID: <353ac8d2-1fff-4772-bdc4-561a63cb326d@suse.de> (raw)
In-Reply-To: <20261116213702.225970-7-dlemoal@kernel.org>
On 11/16/26 10:36 PM, Damien Le Moal wrote:
> For oredered zone append commands, the function
> zloop_set_zone_append_sector() increments a zone write pointer without
> checking if the zone is already open (implicitly or explicitly). This
> check is done only when the command is later executed using a work item,
> and the zone is only then implicitly open if needed. This creates a short
> time window where a report zone can show an empty zone with a write
> pointer that is not equal to the zone start sector, which is incorrect.
>
> Calling zloop_do_open_zone() in zloop_set_zone_append_sector() is required
> but introduces locking complexity as the zone mutex cannot be taken in the
> context of zloop_queue_rq(). Instead introduce the ordered workqueue
> append_workqueue to handle zone append commands when ordered zone append
> is enabled. This ensure that all zone append operations are executed in
> the order of there submission. This removes the need for setting the
> command sector in the context of zloop_queue_rq() and we can rely on the
> reguar command execution done by zloop_rw(). With this change,
> zloop_seq_write_prep() is simplified and zloop_set_zone_append_sector() is
> removed entirely.
>
> This change does reduce the command execution concurrency and impact
> performance with ordered zone append enabled for file systems using zone
> append. This is however not a critical option and the default unordered
> zone append handling is unaffected.
>
> Fixes: fcc6eaa3a03a ("zloop: introduce the ordered_zone_append configuration parameter")
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/block/zloop.c | 113 +++++++++++++++++-------------------------
> 1 file changed, 45 insertions(+), 68 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@kernel.org>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2026-11-19 7:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 21:36 [PATCH v11 00/13] Add support for storage element depopulation Damien Le Moal
2026-11-16 21:36 ` [PATCH v11 01/13] block: introduce disk_zone_is_offline() Damien Le Moal
2026-11-16 21:36 ` [PATCH v11 02/13] block: refactor blk_revalidate_disk_zones() Damien Le Moal
2026-11-16 21:36 ` [PATCH v11 03/13] block: allow dropping all zone write plugs on revalidation Damien Le Moal
2026-11-16 21:36 ` [PATCH v11 04/13] block: introduce storage element management Damien Le Moal
2026-11-16 21:36 ` [PATCH v11 05/13] block: add storage element management ioctls Damien Le Moal
2026-11-16 21:36 ` [PATCH v11 06/13] zloop: fix ordered zone append handling Damien Le Moal
2026-11-19 7:19 ` Hannes Reinecke [this message]
2026-11-16 21:36 ` [PATCH v11 07/13] zloop: fix zone reporting consistency Damien Le Moal
2026-11-16 21:36 ` [PATCH v11 08/13] zloop: add storage element emulation Damien Le Moal
2026-11-19 7:24 ` Hannes Reinecke
2026-11-19 12:57 ` Damien Le Moal
2026-11-16 21:36 ` [PATCH v11 09/13] zloop: add degrade_element control command Damien Le Moal
2026-11-16 21:36 ` [PATCH v11 10/13] scsi: scsi_proto: refine the definition of storage element health Damien Le Moal
2026-11-16 21:37 ` [PATCH v11 11/13] scsi: sd_zbc: always revalidate zones for disks supporting head depopulation Damien Le Moal
2026-11-16 21:37 ` [PATCH v11 12/13] scsi: sd_zbc: define storage element management operations Damien Le Moal
2026-11-19 7:24 ` Hannes Reinecke
2026-11-16 21:37 ` [PATCH v11 13/13] scsi: sd: fail read commands to offline zones early Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=353ac8d2-1fff-4772-bdc4-561a63cb326d@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox