From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C3C0C433E0 for ; Tue, 14 Jul 2020 09:55:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 434B220657 for ; Tue, 14 Jul 2020 09:55:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726187AbgGNJzV (ORCPT ); Tue, 14 Jul 2020 05:55:21 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:2473 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725884AbgGNJzV (ORCPT ); Tue, 14 Jul 2020 05:55:21 -0400 Received: from lhreml724-chm.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id C83168AC16D3B220A8C0; Tue, 14 Jul 2020 10:55:19 +0100 (IST) Received: from [127.0.0.1] (10.47.10.169) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Tue, 14 Jul 2020 10:55:18 +0100 Subject: Re: [PATCH RFC v7 12/12] hpsa: enable host_tagset and switch to MQ To: Ming Lei CC: Hannes Reinecke , , , , , , , , , , , , , , , References: <1591810159-240929-1-git-send-email-john.garry@huawei.com> <1591810159-240929-13-git-send-email-john.garry@huawei.com> <939891db-a584-1ff7-d6a0-3857e4257d3e@huawei.com> <3b3ead84-5d2f-dcf2-33d5-6aa12d5d9f7e@suse.de> <4319615a-220b-3629-3bf4-1e7fd2d27b92@huawei.com> <20200714080631.GA600766@T590> From: John Garry Message-ID: <3584bcc3-830a-d50d-bb55-8ac0b686cdc0@huawei.com> Date: Tue, 14 Jul 2020 10:53:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20200714080631.GA600766@T590> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.10.169] X-ClientProxiedBy: lhreml738-chm.china.huawei.com (10.201.108.188) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 14/07/2020 09:06, Ming Lei wrote: >> v7 is here: >> >> https://github.com/hisilicon/kernel-dev/commits/private-topic-blk-mq-shared-tags-rfc-v7 >> >> So that should be good to test with for now. >> >> And I was going to ask this same question about smartpqi, so can you please >> let me know about this one? Hi Ming, > smartpqi is real MQ HBA, do you need any change wrt. shared tags? Is it really? As I see, today it maintains a single tagset per HBA. So Hannes' change in this series seems ok. However, I do worry that mainline code may be wrong, as block layer may send can_queue * nr_hw_queues requests, when it seems the HBA can only handle can_queue requests. Thanks, john