Re: [RFC PATCH 00/21] block: add and use init tagset helper

[Chaitanya Kulkarni <chaitanyak@nvidia.com>]

On 10/10/22 00:55, Christoph Hellwig wrote:
> On Fri, Oct 07, 2022 at 11:26:13AM -0700, Luis Chamberlain wrote:
>> *If* there were commonalities at init and these could be broken up into
>> common groups, each having their own set of calls, then we simplify and
>> can abstract these. I say this without doing a complete review of the
>> removals, but if there really isn't much of commonalities I tend to
>> agree with Bart that open coding this is better.
> 
> The commonality is that there are various required or optional
> fields to fill out.  I actually have a WIP series to make the tag_set
> dynamically allocated and refcounted to fix some long standing life time
> issues.  That creates a new alloc helper that will take a few mandatory
> arguments and would heavily clash with this series.

I sent out a series based on the feedback I got on this RFC
that complies to the work we have done so far, it does not add more than
5 args and remove the duplicate code in the tree, please have a look.

-ck