From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: Re: [PATCH v7 11/16] block: retry zone revalidation on capacity change
Date: Thu, 10 Sep 2026 14:26:16 +0900 [thread overview]
Message-ID: <35a79f38-b8c5-4ffa-a0c3-5ecdf4a52d61@kernel.org> (raw)
In-Reply-To: <20260910052403.GA27133@lst.de>
On 9/10/26 14:24, Christoph Hellwig wrote:
> On Tue, Sep 08, 2026 at 05:57:40PM +0900, Damien Le Moal wrote:
>> When disk_revalidate_zone_resources() detects a capacity change, -ENODEV
>> is returned, failing the disk revalidation. However, since a capacity
>> change may happen due to a storage element removal being executed
>> concurrently to blk_revalidate_disk_zones(), we can simply retry the
>> revalidation to capture the new zone state with the new capacity without
>> failing the revalidation.
>>
>> Retrying the revalidation is driven by disk_revalidate_zone_resources()
>> returning -EAGAIN when a new valid capacity is detected. And to avoid
>> getting stuck in an infinite loop revalidating zones, retries are limited
>> to 2.
>
> I thought our random pulled out the air retyr numbers was 3 :)
Retry=2 leads to 3 tries since the first one is a try and not a RE-try :)
>
> Either way, this looks fine:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-09-10 5:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 8:57 [PATCH v7 00/16] Improve handling of offline and read-only zones Damien Le Moal
2026-09-08 8:57 ` [PATCH v7 01/16] block: remove disk_free_zone_resources() Damien Le Moal
2026-09-08 8:57 ` [PATCH v7 02/16] block: improve capacity handling during zone revalidation Damien Le Moal
2026-09-09 8:51 ` Hannes Reinecke
2026-09-10 5:20 ` Christoph Hellwig
2026-09-08 8:57 ` [PATCH v7 03/16] block: refactor disk_revalidate_zone_resources() Damien Le Moal
2026-09-08 8:57 ` [PATCH v7 04/16] block: refactor disk_update_zone_resources() Damien Le Moal
2026-09-09 9:09 ` Hannes Reinecke
2026-09-10 5:20 ` Christoph Hellwig
2026-09-08 8:57 ` [PATCH v7 05/16] block: remember a zone type regardless of its condition Damien Le Moal
2026-09-08 8:57 ` [PATCH v7 06/16] block: refactor bdev_zone_is_seq() Damien Le Moal
2026-09-08 8:57 ` [PATCH v7 07/16] block: improve blkdev_get_zone_info() Damien Le Moal
2026-09-09 9:11 ` Hannes Reinecke
2026-09-10 5:21 ` Christoph Hellwig
2026-09-08 8:57 ` [PATCH v7 08/16] block: introduce disk_for_all_zone_wplugs() Damien Le Moal
2026-09-08 8:57 ` [PATCH v7 09/16] block: serialize zone revalidation Damien Le Moal
2026-09-09 9:20 ` Hannes Reinecke
2026-09-10 5:21 ` Christoph Hellwig
2026-09-08 8:57 ` [PATCH v7 10/16] block: drop all zone write plugs on capacity changes Damien Le Moal
2026-09-08 8:57 ` [PATCH v7 11/16] block: retry zone revalidation on capacity change Damien Le Moal
2026-09-09 9:26 ` Hannes Reinecke
2026-09-10 5:24 ` Christoph Hellwig
2026-09-10 5:26 ` Damien Le Moal [this message]
2026-09-08 8:57 ` [PATCH v7 12/16] block: propagate readonly and offline conditions to zone write plugs Damien Le Moal
2026-09-08 8:57 ` [PATCH v7 13/16] block: always treat offline and read-only zones as dead Damien Le Moal
2026-09-08 8:57 ` [PATCH v7 14/16] block: fail zone management operations to read-only and offline zones Damien Le Moal
2026-09-08 8:57 ` [PATCH v7 15/16] block: allow read-only and offline conventional zones Damien Le Moal
2026-09-08 8:57 ` [PATCH v7 16/16] block: simplify disk_zone_set_cond() Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35a79f38-b8c5-4ffa-a0c3-5ecdf4a52d61@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox