public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Matthew Wilcox <willy@infradead.org>
Cc: David Sterba <dsterba@suse.cz>,
	Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
	linux-block@vger.kernel.org
Subject: Re: [PATCH] bio: Export bio_add_folio_nofail to modules
Date: Fri, 26 Apr 2024 08:03:56 -0600	[thread overview]
Message-ID: <3604bf42-16a9-438e-a68a-05f3c81383a4@kernel.dk> (raw)
In-Reply-To: <Ziu0But3Q6kc1DhK@casper.infradead.org>

On 4/26/24 8:02 AM, Matthew Wilcox wrote:
> On Fri, Apr 26, 2024 at 07:41:29AM -0600, Jens Axboe wrote:
>> On 4/25/24 10:37 AM, Matthew Wilcox (Oracle) wrote:
>>> Several modules use __bio_add_page() today and may need to be converted
>>> to bio_add_folio_nofail().
>>
>> Confused, we don't have any modular users of this. A change like this
>> should be submitted with a conversion.
> 
> Thank you for reinforcing my point.
> 
> https://lore.kernel.org/linux-fsdevel/ZiqHIH3lIzcRXCkU@casper.infradead.org/
> 
> Can I have an Acked-by so David can take it through the btrfs tree?

Yeah that's fine, makes more sense now than the standalone one:

Reviewed-by: Jens Axboe <axboe@kernel.dk>

-- 
Jens Axboe



  reply	other threads:[~2024-04-26 14:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25 16:37 [PATCH] bio: Export bio_add_folio_nofail to modules Matthew Wilcox (Oracle)
2024-04-26  6:47 ` Johannes Thumshirn
2024-04-26 13:41 ` Jens Axboe
2024-04-26 14:02   ` Matthew Wilcox
2024-04-26 14:03     ` Jens Axboe [this message]
2024-04-30  9:19       ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3604bf42-16a9-438e-a68a-05f3c81383a4@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=dsterba@suse.cz \
    --cc=linux-block@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox