Re: [PATCH blktests] common, tests: Support printing multiple skip reasons

["lizhijian@fujitsu.com" <lizhijian@fujitsu.com>]

Hello Shinichiro

So sorry for the late reply(Just realized that the SMTP got something wrong, previous reply was drop without any notification).

post it again.


On 07/07/2022 19:42, Li, Zhijian wrote:
>
> on 7/7/2022 6:58 PM, Shinichiro Kawasaki wrote:
>> ... group_requires() should add strings to the \$SKIP_REASONS array which
>> describe why the group cannot be run.
>>
>>>   #
>>>   # Usually, group_requires() just needs to check that any necessary programs and
>>>   # kernel features are available using the _have_foo helpers. If
>>> -# group_requires() sets \$SKIP_REASON, all tests in this group will be skipped.
>>> +# group_requires() sets \$SKIP_REASONS, all tests in this group will be skipped.
>> ... group_requires() adds strings to \$SKIP_REASONS, all tests in this ...
>
> I tried to do that as your suggestion. It causes a side effect that in order to make
> the line length less than 80 bytes, we have to update all its subsequent lines in the
> samesection. Is it okay? VVV
>
>  # TODO: if this test group has extra requirements for what devices it can be
>  # run on, it should define a group_device_requires() function. If tests in this
> -# group cannot be run on the test device, it should set the \$SKIP_REASONS
> -# variable. \$TEST_DEV is the full path of the block device (e.g., /dev/nvme0n1
> -# or /dev/sda1), and \$TEST_DEV_SYSFS is the sysfs path of the disk (not the
> -# partition, e.g., /sys/block/nvme0n1 or /sys/block/sda). If the target device
> -# is a partition device, \$TEST_DEV_PART_SYSFS is the sysfs path of the
> -# partition device (e.g., /sys/block/nvme0n1/nvme0n1p1 or /sys/block/sda/sda1).
> -# Otherwise, \$TEST_DEV_PART_SYSFS is an empty string.
> +# group cannot be run on the test device, it should  adds strings to
> +# \$SKIP_REASONS. \$TEST_DEV is the full path of the block device (e.g.,
> +# /dev/nvme0n1 # or /dev/sda1), and \$TEST_DEV_SYSFS is the sysfs path of the
> +# disk (not the # partition, e.g., /sys/block/nvme0n1 or /sys/block/sda). If
> +# the target device is a partition device, \$TEST_DEV_PART_SYSFS is the sysfs
> +# path of the partition device (e.g., /sys/block/nvme0n1/nvme0n1p1 or
> +# /sys/block/sda/sda1). Otherwise, \$TEST_DEV_PART_SYSFS is an empty string.
>  #
>  # Usually, group_device_requires() just needs to check that the test device is
>  # the right type of hardware or supports any necessary features using the
>
> Thanks
> Zhijian
>
>