From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8260848C8A3 for ; Tue, 4 Aug 2026 17:19:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863958; cv=none; b=A5DAefG3IY6N6EY0VKR6MN62hVm8ODzYxxM9Raoal11VJboTUdPLMfh5/ZaTuVCk7ka+conZH0oeadX+KH2Kx+FuNpcCr6tWMRClp7BzveHA4BKS5cHbV2h5uFDGlR3hRdKWcKVTNnJND1rS0CZbO/pLXiMwKzUj1CBR7bpiuLw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863958; c=relaxed/simple; bh=fiynAW9WpUzgt3N4BHN/WeqgVQsTYwv6Egh7edSdGZk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jcnvXHMy5yeps8sgEck8U0FYpvTbtz2hq/cWrw0gyEwF3kTo6lzUCKDDjM+m63Y09NuCU9aZaog0SmuKRWBq+B330F1rvXCBxa/gymGbxKOW2OCY/SEqD2TVnR4NKfjug4IlBF8k36MvCcG3uZUa7DXt4E0YT3VIbejiZhvBJ5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gB9JzHh/; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gB9JzHh/" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-47de0093c42so32984f8f.3 for ; Tue, 04 Aug 2026 10:19:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785863949; x=1786468749; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kJpsobbV6cDtzB2hYIU7sj8yXmkuFvAex2Z4hVps0ns=; b=gB9JzHh/xNwbsxwl/HtsyKUVQn66uJpc4fGE3xWBbRBF8Bj789qpQkHuQYRZUI1uZH y1ATPiDHs+timfWEFxnQ8qOmZjfmmj3xYlVR86qIr174/WUoTBm8CWOktDfOtHh+vEqo FY7kiI/3/FOvVzA03rCNK2f7HteezMqmQ/yylnkzHyLH/U1gz6yngtU+KTnWdrdMlvY2 +SSMhgpAcY3pILj1UPd1xvW/yHxQFHlVeFWGr+ikEeeL+JufTVT7HIo7ghRoQCOubnyt juvM34xc6zLxIMGU01B9wEc7AUyyF6GPpYwVIJ6J3IpHXum3mOowlhaN36AJ36Z1POyc EhVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785863949; x=1786468749; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kJpsobbV6cDtzB2hYIU7sj8yXmkuFvAex2Z4hVps0ns=; b=SSEx2wlbuuRZFRwtgp8EDPds74SF+c5p8wn5fIk9cPNo1MzWy9dikkHdeOOCdqYgjm r3OpeV+7JgzQcrw7fbk1fGypJBYTPgy+NxzhOQt2K5LeK+2+UEUw0Tf/Ul3APocJqnTt ogPNCgoGBEA/4/3h+rzglB4afuCwPzViSiIOqRWwICOeTxAcvdmWj1S80kseX6NozRl9 xVUh8wInhus3yqs5qrXFJVp+cXcL/NMeLyQI3fgbn3XX0RUHQva4oeAiQYVB9g4SOvx4 Yu47+5KEUpmanX9ErfMtADHZbg8RbadAyerdZaoxwCJ4CF5x7j3qFf51oLXHtren2OkE xb9w== X-Forwarded-Encrypted: i=1; AHgh+Rr3tfOJSxqgql/p/J/0SIU/x0fDjsn1mUBTI1NI4kCC17mOBPSsPD1HZr4pg71C2/7ldky4TaavvOkKIA==@vger.kernel.org X-Gm-Message-State: AOJu0Yxpmp+5S44M3ab2s831ZFSK5YwM5OezED/qUTY0eoQUYBgiwEof OcXSMLeIUT+EsXNWxOJTg7EDE7bDtGVH5YJT0DL3YvV3FDieMbmnh+5i X-Gm-Gg: AR+sD12RS56o857y5AxB81JB1pib9EitkE2DkV/ZTtPGIiNlRae3KhF2vWfDQNbQ8MS lKvIU5AA4W2xllfRz3MsEbFo0oLAkk82ZIzod9LOAm7gKeVcKbG84JPN4OErOsWZURfybLTGlff yx2EuJRMchlD8sXE3cgGpc2MMFtJvW/Hz1ggHHmqC3UYsLSSEehA03zOA0uhjCey0/Jhal8X+di Nhm7xnfDVq9QQ06Sd5owopCnzf7hJIORl1LDxAIwZEX+rFHIlRaRjOsbOAsTiGV2D4L8PIsrP3l Gueo/E9fpRHUwg1yhkE+DoBm990uQWJAuErVsu5edJBYKS7PEe431x4LDT8F56u7MfEJNYq8ANw NBm+VPwG/BTgYmYNieMzTiFL8aRx038HUugTDbou7yim4Ab1stuhtV8vjyTEceBvblzKEpb1JjJ 5ZBmH9fSqgHLI4ql6PEvNz6YH+XaEoqGf4nEYlfudWRNi9drUF058oQhMBG//7TJExN9x4GGrGE XcEEsOrs4Qld2JyL68sSGKnH2NOgRW5LEPtHlzgmE4BSD1M/Wq2wakJCTELF9AkIORpCh7eCH+f SSCJqQfLy8j3lxYQkGcF/VH4dDej5/Y2x3py758= X-Received: by 2002:adf:fe49:0:b0:47f:941a:796d with SMTP id ffacd0b85a97d-47fec4fa3admr1381301f8f.12.1785863948785; Tue, 04 Aug 2026 10:19:08 -0700 (PDT) Received: from ?IPV6:2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c? ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47febfda6afsm1357370f8f.3.2026.08.04.10.19.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 10:19:07 -0700 (PDT) Message-ID: <38163009-770f-4596-abe2-249efc113f59@gmail.com> Date: Tue, 4 Aug 2026 18:19:02 +0100 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 07/16] block: introduce dma map backed bio type To: Christoph Hellwig Cc: Jens Axboe , Keith Busch , Sagi Grimberg , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Alexander Viro , Christian Brauner , Andrew Morton , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Nitesh Shetty , Kanchan Joshi , Anuj Gupta , Tushar Gohad , William Power , Phil Cayton , Jason Gunthorpe , Damien Le Moal , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , Vishal Verma , David Sterba , Ilya Dryomov , dm-devel@lists.linux.dev, nvdimm@lists.linux.dev, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org References: <20260804162440.GB12292@lst.de> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20260804162440.GB12292@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/4/26 17:24, Christoph Hellwig wrote: > On Sat, Aug 01, 2026 at 04:46:19PM +0100, Pavel Begunkov wrote: >> Premapped buffers don't require a generic bio_vec since these have >> already been dma mapped. Repurpose the bi_io_vec space to strore dmabuf >> maps as they are mutually exclusive. >> >> Suggested-by: Keith Busch >> Signed-off-by: Pavel Begunkov >> --- ...>> >> +static inline int bio_split_io_at_dmabuf(struct bio *bio, >> + const struct queue_limits *lim, unsigned *segs, >> + unsigned max_bytes, unsigned len_align_mask, >> + unsigned start_align_mask) >> +{ >> + unsigned bytes = min(bio->bi_iter.bi_size, max_bytes); >> + unsigned seg_shift = bio->bi_dmabuf_map->seg_shift; >> + unsigned offset = bio->bi_iter.bi_offset & ((1U << seg_shift) - 1); >> + >> + if ((bio->bi_iter.bi_offset & start_align_mask) || >> + (bio->bi_iter.bi_size & len_align_mask)) >> + return -EINVAL; >> + >> + /* single contiguous range into the dma-buf */ >> + *segs = 1; >> + >> + bytes = min(bytes, ((unsigned)lim->max_segments << seg_shift) - offset); > > I guess ->seg_shift is some sort of encoding of a max > segment size? I'll add a comment. We rather need the minimum segment size, you can always split large ones. I calculated it even stricter as the least common multiple pow2 to avoid divs here. If the device supports N segments and we know that each segment is at least M bytes, then we should be able to issue IO of size N*M of full segments. The line above truncates the bio size using that + offset adjustments. I guess it might be more straightforward to calculate the worst case number of segments and then adjust the splitting size, but since we don't return the number of segments it's more computations. E.g. seg_size = 1U << seg_shift; nsegs = (bio->bi_iter.bi_size + offset + seg_size - 1) / seg_size; if (nsegs > lim->max_segments) { nsegs = lim->max_segments; // unused after the block bytes = seg_size * nsegs - offset; } -- Pavel Begunkov