From: Nilay Shroff <nilay@linux.ibm.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, hch@lst.de, axboe@kernel.dk,
sth@linux.ibm.com, gjoyce@ibm.com
Subject: Re: [PATCHv2] block: fix lock dependency between percpu alloc lock and elevator lock
Date: Thu, 5 Jun 2025 11:32:08 +0530 [thread overview]
Message-ID: <38ef98c2-0803-4f1b-af62-55d91bd54b38@linux.ibm.com> (raw)
In-Reply-To: <aD60SF6QGMSPykq-@fedora>
Missed to respond to one of your comments in my previous response.
On 6/3/25 2:07 PM, Ming Lei wrote:
>> -static struct elevator_type *elevator_find_get(const char *name)
>> +struct elevator_type *elevator_find_get(const char *name)
>> {
>> struct elevator_type *e;
>>
>> @@ -128,6 +117,7 @@ static struct elevator_type *elevator_find_get(const char *name)
>> spin_unlock(&elv_list_lock);
>> return e;
>> }
>> +EXPORT_SYMBOL(elevator_find_get);
>
> `elevator_find_get()` is block core internal helper, why do you export it?
>
Yes we don't need to. My bad, we just need to make it non static so
that it could be invoked from other file. I will fix this in next patch.
Thanks,
--Nilay
prev parent reply other threads:[~2025-06-05 6:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 12:33 [PATCHv2] block: fix lock dependency between percpu alloc lock and elevator lock Nilay Shroff
2025-06-03 8:37 ` Ming Lei
2025-06-05 5:52 ` Nilay Shroff
2025-06-09 2:13 ` Ming Lei
2025-06-11 5:41 ` Nilay Shroff
2025-06-05 6:02 ` Nilay Shroff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38ef98c2-0803-4f1b-af62-55d91bd54b38@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=gjoyce@ibm.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=sth@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox