From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: Andrew Jones <drjones@redhat.com>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] blk-mq: avoid to synchronize rcu inside blk_cleanup_queue()
Date: Fri, 22 Jun 2018 16:00:04 -0600 [thread overview]
Message-ID: <39a212af-2b5b-6eb4-e63c-287051717435@kernel.dk> (raw)
In-Reply-To: <20180622213115.GA2949@ming.t460p>
On 6/22/18 3:31 PM, Ming Lei wrote:
>> diff --git a/block/blk-mq.c b/block/blk-mq.c
>> index 8e57b84e50e9..18ad2b95ff63 100644
>> --- a/block/blk-mq.c
>> +++ b/block/blk-mq.c
>> @@ -2351,8 +2351,12 @@ static void blk_mq_update_tag_set_depth(struct blk_mq_tag_set *set,
>> static void blk_mq_del_queue_tag_set(struct request_queue *q)
>> {
>> struct blk_mq_tag_set *set = q->tag_set;
>> + bool shared;
>>
>> mutex_lock(&set->tag_list_lock);
>> +
>> + shared = !list_is_singular(&set->tag_list);
>
> Or:
> shared = set->flags & BLK_MQ_F_TAG_SHARED;
That'd work too, yeah.
--
Jens Axboe
next prev parent reply other threads:[~2018-06-22 22:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 2:55 [PATCH] blk-mq: avoid to synchronize rcu inside blk_cleanup_queue() Ming Lei
2018-06-22 11:42 ` Andrew Jones
2018-06-22 14:58 ` Jens Axboe
2018-06-22 21:31 ` Ming Lei
2018-06-22 22:00 ` Jens Axboe [this message]
2018-06-22 14:47 ` Jens Axboe
2018-06-22 21:33 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39a212af-2b5b-6eb4-e63c-287051717435@kernel.dk \
--to=axboe@kernel.dk \
--cc=drjones@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox