public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Li Chen <me@linux.beauty>, Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] block: rate-limit capacity change info log
Date: Mon, 17 Nov 2025 08:54:35 -0800	[thread overview]
Message-ID: <39e01b9d-2681-459a-84a2-f96ade679764@acm.org> (raw)
In-Reply-To: <20251117053407.70618-1-me@linux.beauty>

On 11/16/25 9:34 PM, Li Chen wrote:
> From: Li Chen <chenl311@chinatelecom.cn>
> 
> loop devices under heavy stress-ng loop streessor can trigger many
> capacity change events in a short time. Each event prints an info
> message from set_capacity_and_notify(), flooding the console and
> contributing to soft lockups on slow consoles.
> 
> Switch the printk in set_capacity_and_notify() to
> pr_info_ratelimited() so frequent capacity changes do not spam
> the log while still reporting occasional changes.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Li Chen <chenl311@chinatelecom.cn>
> ---
>   block/genhd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/genhd.c b/block/genhd.c
> index 9bbc38d12792..bd3a6841e5b5 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -90,7 +90,7 @@ bool set_capacity_and_notify(struct gendisk *disk, sector_t size)
>   	    (disk->flags & GENHD_FL_HIDDEN))
>   		return false;
>   
> -	pr_info("%s: detected capacity change from %lld to %lld\n",
> +	pr_info_ratelimited("%s: detected capacity change from %lld to %lld\n",
>   		disk->disk_name, capacity, size);
>   
>   	/*

Reviewed-by: Bart Van Assche <bvanassche@acm.org>


  reply	other threads:[~2025-11-17 16:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17  5:34 [PATCH] block: rate-limit capacity change info log Li Chen
2025-11-17 16:54 ` Bart Van Assche [this message]
2025-11-17 18:24 ` Chaitanya Kulkarni
2025-11-17 18:30 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39e01b9d-2681-459a-84a2-f96ade679764@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@linux.beauty \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox