* [PATCH 3/6] lightnvm: pblk: fix message if L2P MAP is in device
@ 2017-09-21 11:26 Rakesh Pandit
2017-09-22 8:52 ` Javier González
0 siblings, 1 reply; 5+ messages in thread
From: Rakesh Pandit @ 2017-09-21 11:26 UTC (permalink / raw)
To: Matias Bjørling, linux-block, linux-kernel; +Cc: Javier González
This usually happens if we are developing with qemu and ll2pmode has
default value. Even in that case message seems wrong.
Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
---
drivers/lightnvm/pblk-init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
index 470ef04..c5c1337 100644
--- a/drivers/lightnvm/pblk-init.c
+++ b/drivers/lightnvm/pblk-init.c
@@ -913,7 +913,7 @@ static void *pblk_init(struct nvm_tgt_dev *dev, struct gendisk *tdisk,
int ret;
if (dev->identity.dom & NVM_RSP_L2P) {
- pr_err("pblk: device-side L2P table not supported. (%x)\n",
+ pr_err("pblk: device-side L2P table supported. (%x)\n",
dev->identity.dom);
return ERR_PTR(-EINVAL);
}
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 3/6] lightnvm: pblk: fix message if L2P MAP is in device
2017-09-21 11:26 [PATCH 3/6] lightnvm: pblk: fix message if L2P MAP is in device Rakesh Pandit
@ 2017-09-22 8:52 ` Javier González
2017-09-22 9:44 ` Rakesh Pandit
2017-09-25 10:15 ` Matias Bjørling
0 siblings, 2 replies; 5+ messages in thread
From: Javier González @ 2017-09-22 8:52 UTC (permalink / raw)
To: Rakesh Pandit; +Cc: Matias Bjørling, linux-block, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]
> On 21 Sep 2017, at 13.26, Rakesh Pandit <rakesh@tuxera.com> wrote:
>
> This usually happens if we are developing with qemu and ll2pmode has
> default value. Even in that case message seems wrong.
>
> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
> ---
> drivers/lightnvm/pblk-init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
> index 470ef04..c5c1337 100644
> --- a/drivers/lightnvm/pblk-init.c
> +++ b/drivers/lightnvm/pblk-init.c
> @@ -913,7 +913,7 @@ static void *pblk_init(struct nvm_tgt_dev *dev, struct gendisk *tdisk,
> int ret;
>
> if (dev->identity.dom & NVM_RSP_L2P) {
> - pr_err("pblk: device-side L2P table not supported. (%x)\n",
> + pr_err("pblk: device-side L2P table supported. (%x)\n",
> dev->identity.dom);
> return ERR_PTR(-EINVAL);
> }
> --
> 2.5.0
You're right. This is inherited from rrpc.
Can we instead write "pblk: full host-side L2P table not supported"?
People will not know about the hybrid device/host L2P as time goes by
and it will just be confusing. I'm not even sure this will be part of
the 2.0 spec, so it will probably go away with time...
Javier
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 3/6] lightnvm: pblk: fix message if L2P MAP is in device
2017-09-22 8:52 ` Javier González
@ 2017-09-22 9:44 ` Rakesh Pandit
2017-09-22 10:03 ` Javier González
2017-09-25 10:15 ` Matias Bjørling
1 sibling, 1 reply; 5+ messages in thread
From: Rakesh Pandit @ 2017-09-22 9:44 UTC (permalink / raw)
To: Javier González; +Cc: Matias Bjørling, linux-block, linux-kernel
On Fri, Sep 22, 2017 at 10:52:19AM +0200, Javier Gonz�lez wrote:
> > On 21 Sep 2017, at 13.26, Rakesh Pandit <rakesh@tuxera.com> wrote:
> >
> > This usually happens if we are developing with qemu and ll2pmode has
> > default value. Even in that case message seems wrong.
> >
> > Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
> > ---
> > drivers/lightnvm/pblk-init.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
> > index 470ef04..c5c1337 100644
> > --- a/drivers/lightnvm/pblk-init.c
> > +++ b/drivers/lightnvm/pblk-init.c
> > @@ -913,7 +913,7 @@ static void *pblk_init(struct nvm_tgt_dev *dev, struct gendisk *tdisk,
> > int ret;
> >
> > if (dev->identity.dom & NVM_RSP_L2P) {
> > - pr_err("pblk: device-side L2P table not supported. (%x)\n",
> > + pr_err("pblk: device-side L2P table supported. (%x)\n",
> > dev->identity.dom);
> > return ERR_PTR(-EINVAL);
> > }
> > --
> > 2.5.0
>
> You're right. This is inherited from rrpc.
>
> Can we instead write "pblk: full host-side L2P table not supported"?
> People will not know about the hybrid device/host L2P as time goes by
> and it will just be confusing. I'm not even sure this will be part of
> the 2.0 spec, so it will probably go away with time...
>
Sure. I was confused the first time. This is better.
It would be great if this is done while picking up. I can repost as
well if need be.
Thanks,
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 3/6] lightnvm: pblk: fix message if L2P MAP is in device
2017-09-22 9:44 ` Rakesh Pandit
@ 2017-09-22 10:03 ` Javier González
0 siblings, 0 replies; 5+ messages in thread
From: Javier González @ 2017-09-22 10:03 UTC (permalink / raw)
To: Rakesh Pandit; +Cc: Matias Bjørling, linux-block, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1677 bytes --]
Sure.
Matias: Can you fix this when picking it up?
Javier
> On 22 Sep 2017, at 11.44, Rakesh Pandit <rakesh@tuxera.com> wrote:
>
> On Fri, Sep 22, 2017 at 10:52:19AM +0200, Javier González wrote:
>>> On 21 Sep 2017, at 13.26, Rakesh Pandit <rakesh@tuxera.com> wrote:
>>>
>>> This usually happens if we are developing with qemu and ll2pmode has
>>> default value. Even in that case message seems wrong.
>>>
>>> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
>>> ---
>>> drivers/lightnvm/pblk-init.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
>>> index 470ef04..c5c1337 100644
>>> --- a/drivers/lightnvm/pblk-init.c
>>> +++ b/drivers/lightnvm/pblk-init.c
>>> @@ -913,7 +913,7 @@ static void *pblk_init(struct nvm_tgt_dev *dev, struct gendisk *tdisk,
>>> int ret;
>>>
>>> if (dev->identity.dom & NVM_RSP_L2P) {
>>> - pr_err("pblk: device-side L2P table not supported. (%x)\n",
>>> + pr_err("pblk: device-side L2P table supported. (%x)\n",
>>> dev->identity.dom);
>>> return ERR_PTR(-EINVAL);
>>> }
>>> --
>>> 2.5.0
>>
>> You're right. This is inherited from rrpc.
>>
>> Can we instead write "pblk: full host-side L2P table not supported"?
>> People will not know about the hybrid device/host L2P as time goes by
>> and it will just be confusing. I'm not even sure this will be part of
>> the 2.0 spec, so it will probably go away with time...
>
> Sure. I was confused the first time. This is better.
>
> It would be great if this is done while picking up. I can repost as
> well if need be.
>
> Thanks,
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/6] lightnvm: pblk: fix message if L2P MAP is in device
2017-09-22 8:52 ` Javier González
2017-09-22 9:44 ` Rakesh Pandit
@ 2017-09-25 10:15 ` Matias Bjørling
1 sibling, 0 replies; 5+ messages in thread
From: Matias Bjørling @ 2017-09-25 10:15 UTC (permalink / raw)
To: Javier González, Rakesh Pandit; +Cc: linux-block, linux-kernel
On 09/22/2017 10:52 AM, Javier Gonz�lez wrote:
>> On 21 Sep 2017, at 13.26, Rakesh Pandit <rakesh@tuxera.com> wrote:
>>
>> This usually happens if we are developing with qemu and ll2pmode has
>> default value. Even in that case message seems wrong.
>>
>> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
>> ---
>> drivers/lightnvm/pblk-init.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
>> index 470ef04..c5c1337 100644
>> --- a/drivers/lightnvm/pblk-init.c
>> +++ b/drivers/lightnvm/pblk-init.c
>> @@ -913,7 +913,7 @@ static void *pblk_init(struct nvm_tgt_dev *dev, struct gendisk *tdisk,
>> int ret;
>>
>> if (dev->identity.dom & NVM_RSP_L2P) {
>> - pr_err("pblk: device-side L2P table not supported. (%x)\n",
>> + pr_err("pblk: device-side L2P table supported. (%x)\n",
>> dev->identity.dom);
>> return ERR_PTR(-EINVAL);
>> }
>> --
>> 2.5.0
>
> You're right. This is inherited from rrpc.
>
> Can we instead write "pblk: full host-side L2P table not supported"?
> People will not know about the hybrid device/host L2P as time goes by
> and it will just be confusing. I'm not even sure this will be part of
> the 2.0 spec, so it will probably go away with time...
>
> Javier
>
Thanks, I picked it up.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-25 10:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-21 11:26 [PATCH 3/6] lightnvm: pblk: fix message if L2P MAP is in device Rakesh Pandit
2017-09-22 8:52 ` Javier González
2017-09-22 9:44 ` Rakesh Pandit
2017-09-22 10:03 ` Javier González
2017-09-25 10:15 ` Matias Bjørling
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).