From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D70C761A6 for ; Wed, 29 Mar 2023 23:31:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229895AbjC2XbW (ORCPT ); Wed, 29 Mar 2023 19:31:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229764AbjC2XbT (ORCPT ); Wed, 29 Mar 2023 19:31:19 -0400 Received: from esa6.hgst.iphmx.com (esa6.hgst.iphmx.com [216.71.154.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 208B2420B for ; Wed, 29 Mar 2023 16:31:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680132678; x=1711668678; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=UNlm9Cgnb69c4/O/u7KM3nCJu6vgziKIZ4YaTqHtuUE=; b=Zjg7dg8p+fjLvNjK85BbXq/dPqHa7FY63D9N7TjaILgZtYXJzQp04Lbj T3HoMvrPtyxVfJObcJogfKLakV6t/8XMIcOfmUPOPKHtEgNDQvhALmJPd IgnPaHI9lnst/7NajeSMpKNzxg3AJtfS2OX/quWbHnegqeZ0v9OrOaf2T ATERS2Itsocp2zPaXbApE3VahiI5x6IiE9MrTdwiaIIVTDIDuLws2jZuV tfA5MvY+FqH7aGEz80vGuv3QAO29wtT8Ixcfsn4kpejCb2ea72THy418U bMYw+YzLQpYU4x7OvTfiXF9ibMhvg5aVVwiYIOCrZDY2xt7B6abqGeijT A==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="226828446" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:31:16 +0800 IronPort-SDR: ug2+oM7g8vgB7PTHly4fBuw2mJGO714lXnW+vKlc7nnwGxA2fylH1tO8fxmshVY3uZHdlGwuT5 1jFOrYsWXs/1qKkDbc/jDjwawwIYfnWWMrat/WCcAP1tqTP+B4LAYdGF/CmJyhx6IMljNLeUKq Keo3XnbG5ethGqlqWCfTE/4+jNc4a6htMf6FDtWwFywi4cSzO6hPVRY2UbqvJ5kXf5M5/hRrkL zgylb5v3CGYluBa8K/iyLsiazAnslH6aSxKRdhTv6sVdw8v2MvD3QSs6+urPrr2o3/s/a3iEYp UU0= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:41:45 -0700 IronPort-SDR: szdV2XeNtYUR5/VnyTkoE84Kzmj+YNLbI2DttjAfFvbxL/c6Hie+KARghIWW2nZ0/0YZuK6EZF 4/cm5su/ED0haxCHAxfQE+NAVedUxfe1ttfqy0S1DCBYPjxaGju4vaTt343ATbphkoMYGS4nMP 7+RGiE61YNYWzEL1TjazvmoMxBLqyz0OhwkAoISIslIMeEIrYbm0Hkx1zZzuzmLg1YOcMChaPi 5i/j3VZFjcBZss/M/cVWjoAEStDYfZLa07tQjqlXTFyQgi+3Hjcbr1S0WlHIRarrwnr4xX4viB JGc= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:31:16 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2qm0c99z1RtW1 for ; Wed, 29 Mar 2023 16:31:16 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680132675; x=1682724676; bh=UNlm9Cgnb69c4/O/u7KM3nCJu6vgziKIZ4Y aTqHtuUE=; b=Ca2fO6rcxglppHNXYxRAHziKkRlfWQdPRtKcotDpyHFiP/dqL1l +eRINX7r2eICbC4KQtNpc23E7B6cTVrRj9Ksclu4Jqd/OhE7FGf0WFts4RSkNvRZ vyDh64QjNua4rA3LG9nobAs9hY5rxbY67Vr2/TNnOHh89mZ8LeAkwGHM4RGHVU7Q G2zLU+l3brOhyc7kjdil5v6zpK4QdjwQTJ4zW86BPD9Cb/sL1GpTuVvrOGcehbqI 6BtW6hfXgSgZ2432WxO3xb5C7AONp6W2nDb+sKaqwGk9QuSWfywQR32EdxP4QOPx RFADdkCfux4rv8H/ZisxP0MjM4uYkF1VzgA== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id M9GxmqBGHf2R for ; Wed, 29 Mar 2023 16:31:15 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2qh3MbGz1RtVm; Wed, 29 Mar 2023 16:31:12 -0700 (PDT) Message-ID: <3ba0a4e1-7b75-9d0c-d6d3-dfc3d4bbbef0@opensource.wdc.com> Date: Thu, 30 Mar 2023 08:31:11 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 04/19] fs: buffer: use __bio_add_page to add single page to bio Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <56321f8ef1e70e9e541074593575b74d3e25ade2.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <56321f8ef1e70e9e541074593575b74d3e25ade2.1680108414.git.johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 3/30/23 02:05, Johannes Thumshirn wrote: > The buffer_head submission code uses bio_add_page() to add a page to a > newly created bio. bio_add_page() can fail, but the return value is never > checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research