From: Jens Axboe <axboe@kernel.dk>
To: weiping <zhangweiping@didichuxing.com>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] blk-mq-debugfs: add mapping show for hw queue to cpu
Date: Wed, 12 Jul 2017 11:25:12 -0600 [thread overview]
Message-ID: <3d69dcde-2f8e-b7e3-5a3a-f0cb7f8caee8@kernel.dk> (raw)
In-Reply-To: <20170712171331.GA13374@localhost.didichuxing.com>
On 07/12/2017 11:13 AM, weiping zhang wrote:
> On Wed, Jul 12, 2017 at 10:57:37AM -0600, Jens Axboe wrote:
>> On 07/12/2017 10:54 AM, weiping zhang wrote:
>>> A mapping show as following:
>>>
>>> hctx cpus
>>> hctx0 0 1
>>> hctx1 2
>>> hctx2 3
>>> hctx3 4 5
>>
>> We already have that information in the /sys/block/<dev>/mq/X/cpu_list
>>
>> where X is the hardware queue number. Why do we need it in debugfs as
>> well, presented differently?
>
> this arribute give a more obviously showing, only by 1 "cat" command.
> /sys/bloc/<dev>/mq/X/cpu_list not easy get mapping for all hctx by 1
> command.
> also /sys/kernel/debug/block/xxx/hctxN/cpuX can export that info, but
> these two methods both not obviously.
The point is the information is there, and I'm sure most people can
work out the shell logic to collect this info. I see zero benefit to
adding this to debugfs.
--
Jens Axboe
next prev parent reply other threads:[~2017-07-12 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 16:54 [PATCH] blk-mq-debugfs: add mapping show for hw queue to cpu weiping zhang
2017-07-12 16:57 ` Jens Axboe
2017-07-12 17:13 ` weiping zhang
2017-07-12 17:25 ` Jens Axboe [this message]
2017-07-13 14:09 ` weiping zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d69dcde-2f8e-b7e3-5a3a-f0cb7f8caee8@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=zhangweiping@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox