From: Jens Axboe <axboe@kernel.dk>
To: Daniel Vacek <neelx@redhat.com>, Tejun Heo <tj@kernel.org>,
Josef Bacik <josef@toxicpanda.com>
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-cgroup: clean up after commit f1c006f1c685
Date: Thu, 4 Jan 2024 16:06:46 -0700 [thread overview]
Message-ID: <3de0c147-0a6e-47ad-90dd-cc624da6200b@kernel.dk> (raw)
In-Reply-To: <20240104180031.148148-1-neelx@redhat.com>
On 1/4/24 11:00 AM, Daniel Vacek wrote:
> Commit f1c006f1c685 moved deletion of the list blkg->q_node
> from blkg_destroy() to blkg_free_workfn(). Clean up the now
> useless variable.
I'll fix up your commit this time, but please take a look at
your title and tell me if you think it's a good one? Not
very descriptive, is it.
--
Jens Axboe
next prev parent reply other threads:[~2024-01-04 23:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 18:00 [PATCH] blk-cgroup: clean up after commit f1c006f1c685 Daniel Vacek
2024-01-04 21:57 ` Tejun Heo
2024-01-04 23:06 ` Jens Axboe [this message]
2024-01-04 23:10 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3de0c147-0a6e-47ad-90dd-cc624da6200b@kernel.dk \
--to=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neelx@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox