From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.71 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794192731; b=XwTrn9k81ZdXDzflAXbDtOtwYvz98BDBdaZNI2YgmxSQwq1U1vKN77b3xeCgkJhthxrG ONxcvdT/zEv4JpBeynVYjNBrJrOgbezEcGBM7KDNfZmj1ZbbpPZI4JhxMQstMX6h56wKc bTUtxBw0TSJz0u5NSR2DtONdpJigOW48gA3keUiwXmzjxjzQ/RQOXFoHwoSp6j1VEgS8W 2Svou7PFe8ry23aa7d8hMbEKC30ueeQSVZwwx6vfVmj3OLjXIoUMtXD+d6zqxozPQk0DK vir2L3AdNFTxtwdManhcFexgGnNSaoWSPnzyqK2W0ZocXTeeHy03XMyM61Y5y2MO6IA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794192731; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=nWqWiduDQX/+eDY/lBNMvXq4xgQ2WR9If/niokbocYQ=; b=WAb/fFOr5Kor/BwnwnNiQVDQQHoJvbNXkp+0T72VWGAa28ZENFP05KlsEeMKbf6EvcZY WmJKDzU6Rw8cFKwNmMsn+cdoLpEMC3Ouej785YjUdBh4bIvDqM7ne4pYow5s1typW6R6M B61FHBq9T360rkK4Jgk+1sDqYQg9pX+TMYIpuzPze5zh85Bpr1PKGNoIpy7zdpweNjMe/ eI7GBSAJQeTWkHrk0nEvOmM7u20lGkP3+FnVjFKrbHTyWb9x5RxhagEq6a9VTBPFeYiFX wMuUCcNxdAeMB9uE2sqvMpaFjiwnSI2gK7xb8oHgLrfkdhlJjGZLKJj6l1N/yQuxqlg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; arc=none smtp.remote-ip=95.215.58.71 Received: from mta1.migadu.com (out-71.mta1.migadu.com [95.215.58.71]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75B90606A31C for ; Mon, 9 Nov 2026 02:52:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 75B90606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Envelope-To: linux-block@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=1zQrA1miKQ/sO3U4FLD9eN7ND1EAn4eFHq58nFmS/2c=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794192722; v=1; x=1794797522; b=pKqbz5+1nAKvoDjratDGIzCVYLRnYWqr1KkI/51AbwTsIOLh1H3KSkwjZnitIUapDrfX3moK iBDOjWlEa0LcAglhZ0IIVJXQpa10JvLhgoeorLL1bBrmrzYqTSk7F/F73Ux8tJumFsmES18Q1nY WVU2IQ4+YlREcEp/U62zWKW0= X-Envelope-To: linux-block@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id f8a5242679d67f97; Mon, 09 Nov 2026 02:52:02 +0000 X-Mizu-Trace-ID: f8a5242679d67f97 X-Migadu-Flow: FLOW_OUT Message-ID: <3f45a5f9-9c87-420d-b6a5-6145c834c0d1@linux.dev> Date: Mon, 9 Nov 2026 10:51:46 +0800 X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 1/6] block: refuse a dma-buf bio that carries a crypto context To: Christoph Hellwig Cc: Jens Axboe , Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , tytso@mit.edu, Andreas Dilger , Baokun Li , Ojaswin Mujoo , "Ritesh Harjani (IBM)" , Zhang Yi , "Darrick J. Wong" , Andrew Morton , asml.silence@gmail.com, Anuj Gupta , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, Li Wang References: <20261105065847.196540-1-mengmeng.zhao@linux.dev> <20261105065847.196540-2-mengmeng.zhao@linux.dev> <20261106104119.GA5668@lst.de> From: Mengmeng Zhao In-Reply-To: <20261106104119.GA5668@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/6/26 18:41, Christoph Hellwig wrote: > On Thu, Nov 05, 2026 at 02:58:42PM +0800, Mengmeng Zhao wrote: >> + /* a dma-buf bio has no pages for integrity work or contents crypto */ >> if (unlikely(op_is_dmabuf(bio->bi_opf) && >> - bdev_has_integrity_csum(bio->bi_bdev))) { >> + (bdev_has_integrity_csum(bio->bi_bdev) || >> + bio_has_crypt_ctx(bio)))) { > > This could really use a factored helper explaining all the refusals. > And maybe we should use the chance to sit back and think what else > would blow up and add it there as well. > Hi Christoph, thanks for the review. I will extract a helper in V2 soon. There are several buffered io fallbacks, it's really necessary to discuss how to avoid these. Glad to join it.