From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, "axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 2/2] fs: remove fs.f_write_hint
Date: Tue, 8 Mar 2022 22:20:01 +0000 [thread overview]
Message-ID: <3ffdbd55-e128-74e5-33bc-f5c5b487b206@nvidia.com> (raw)
In-Reply-To: <20220308060529.736277-3-hch@lst.de>
On 3/7/22 22:05, Christoph Hellwig wrote:
> The value is now completely unused except for reporting it back through
> the F_GET_FILE_RW_HINT ioctl, so remove the value and the two ioctls
> for it.
>
> Trying to use the F_SET_FILE_RW_HINT and F_GET_FILE_RW_HINT fcntls will
> now return EINVAL, just like it would on a kernel that never supported
> this functionality in the first place.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/fcntl.c | 18 ------------------
this follows the discussion on the other tread of returning EINVAL.
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
next prev parent reply other threads:[~2022-03-08 22:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 6:05 remove write hint leftovers v2 Christoph Hellwig
2022-03-08 6:05 ` [PATCH 1/2] fs: remove kiocb.ki_hint Christoph Hellwig
2022-03-08 22:19 ` Chaitanya Kulkarni
2022-03-08 23:09 ` Dave Chinner
2022-03-09 0:55 ` Jens Axboe
2022-03-22 2:13 ` Jens Axboe
2022-03-22 2:45 ` Matthew Wilcox
2022-03-22 2:50 ` Jens Axboe
2022-03-22 2:57 ` Keith Busch
2022-03-22 3:00 ` Jens Axboe
2022-03-08 6:05 ` [PATCH 2/2] fs: remove fs.f_write_hint Christoph Hellwig
2022-03-08 22:20 ` Chaitanya Kulkarni [this message]
2022-03-08 23:11 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2022-03-07 10:46 remove write hint leftovers Christoph Hellwig
2022-03-07 10:47 ` [PATCH 2/2] fs: remove fs.f_write_hint Christoph Hellwig
2022-03-07 13:52 ` Jens Axboe
2022-03-13 1:05 ` Al Viro
2022-03-14 8:02 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ffdbd55-e128-74e5-33bc-f5c5b487b206@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox