From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] blk-mq: don't handle non-flush requests in blk_insert_flush
Date: Tue, 19 Oct 2021 11:10:25 -0600 [thread overview]
Message-ID: <3fffc188-106e-8c12-be32-ebbe717444cd@kernel.dk> (raw)
In-Reply-To: <20211019122553.2467817-1-hch@lst.de>
On 10/19/21 6:25 AM, Christoph Hellwig wrote:
> Return to the normal blk_mq_submit_bio flow if the bio did not end up
> actually being a flush because the device didn't support it. Note that
> this is basically impossible to hit without special instrumentation given
> that submit_bio_checks already clears these flags usually, so we'd need a
> tight race to actually hit this code path.
>
> With this the call to blk_mq_run_hw_queue for the flush requests can be
> removed given that the actual flush requests are always issued via the
> requeue workqueue which runs the queue unconditionally.
This looks great, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2021-10-19 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 12:25 [PATCH] blk-mq: don't handle non-flush requests in blk_insert_flush Christoph Hellwig
2021-10-19 17:10 ` Jens Axboe [this message]
2021-10-19 17:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fffc188-106e-8c12-be32-ebbe717444cd@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox