Re: [PATCH 01/13] lightnvm: pblk: Line reference fix in GC

Javier González
2019-03-04T07:18:37Z

[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]

> On 27 Feb 2019, at 18.14, Igor Konopko <igor.j.konopko@intel.com> wrote:
>
> This patch fixes the error case in GC when
> we both moves line back to closed state and
> release additional reference, what cause illegal
> transition from closed to free on pblk_line_put
> when only gc to free line state transition is
> allowed using that path.
>
> Signed-off-by: Igor Konopko <igor.j.konopko@intel.com>
> ---
> drivers/lightnvm/pblk-gc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c
> index 2fa118c8eb71..3feadfd9418d 100644
> --- a/drivers/lightnvm/pblk-gc.c
> +++ b/drivers/lightnvm/pblk-gc.c
> @@ -290,8 +290,11 @@ static void pblk_gc_line_prepare_ws(struct work_struct *work)
> fail_free_ws:
> kfree(line_ws);
>
> + /* Line goes back to closed state, so we cannot release additional
> + * reference for line, since we do that only when we want to do
> + * gc to free line state transition.
> + */
> pblk_put_line_back(pblk, line);
> - kref_put(&line->ref, pblk_line_put);
> atomic_dec(&gc->read_inflight_gc);
>
> pblk_err(pblk, "failed to GC line %d\n", line->id);
> --
> 2.17.1

Looks good to me

Reviewed-by: Javier González <javier@javigon.com>

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]