From: Bart Van Assche <bvanassche@acm.org>
To: Christoph Hellwig <hch@lst.de>,
martin.petersen@oracle.com, axboe@kernel.dk
Cc: alim.akhtar@samsung.com, avri.altman@wdc.com,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] scsi: ufs: revert HPB support
Date: Mon, 25 Oct 2021 09:12:14 -0700 [thread overview]
Message-ID: <4199e780-32e5-a1ce-65ba-85e0b7a3eda5@acm.org> (raw)
In-Reply-To: <20211022062011.1262184-1-hch@lst.de>
On 10/21/21 11:20 PM, Christoph Hellwig wrote:
> The HPB support added this merge window is fundanetally flawed as it
> uses blk_insert_cloned_request to insert a cloned request onto the same
> queue as the one that the original request came from, leading to all
> kinds of issues in blk-mq accounting (in addition to this API being
> a special case for dm-mpath that should not see other users).
I do not agree with removing the UFS HPB code from the upstream kernel
at this time.
One of the HPB users promised to look into removing the
blk_insert_cloned_request() call from the UFS HPB code. Shouldn't that
person be given the chance to come up with a patch before removal of the
UFS HPB code is considered?
Additionally, removing the UFS HPB code from the upstream kernel won't
affect UFS users much. As far as I know all HPB users use Android. UFS
HPB is supported by Android 12 and will also be supported by Android 13.
Whether or not this patch is goes upstream won't affect the Android
kernel. I am not aware of any plans to make any changes in the Android
kernel UFS HPB code if this patch would be integrated in the upstream
kernel.
Bart.
next parent reply other threads:[~2021-10-25 16:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211022062011.1262184-1-hch@lst.de>
2021-10-25 16:12 ` Bart Van Assche [this message]
2021-10-25 18:26 ` [PATCH] scsi: ufs: revert HPB support Greg Kroah-Hartman
2021-10-25 18:39 ` Bart Van Assche
2021-10-26 4:13 ` Martin K. Petersen
2021-10-26 7:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4199e780-32e5-a1ce-65ba-85e0b7a3eda5@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox