From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>, snitzer@redhat.com
Cc: agk@redhat.com, pbonzini@redhat.com, dm-devel@redhat.com,
linux-block@vger.kernel.org
Subject: Re: [PATCH v4] dm: don't allow ioctls to targets that don't map to whole devices
Date: Sat, 4 Feb 2017 10:20:10 -0700 [thread overview]
Message-ID: <420daead-8b81-c9ad-87cf-7d2e9ab2fc11@kernel.dk> (raw)
In-Reply-To: <20170204094503.19322-1-hch@lst.de>
On 02/04/2017 02:45 AM, Christoph Hellwig wrote:
> .. at least for unprivileged users. Before we called into the SCSI
> ioctl code to allow excemptions for a few SCSI passthrough ioctls,
> but this is pretty unsafe and except for this call dm knows nothing
> about SCSI ioctls.
>
> As the SCSI ioctl code is now optional, we really don't want to
> drag it in for DM, and the exception is not very useful anyway.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Mike Snitzer <snitzer@redhat.com>
Added, with the acks/reviews from Johannes and Pablo added.
--
Jens Axboe
prev parent reply other threads:[~2017-02-04 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-04 9:45 [PATCH v4] dm: don't allow ioctls to targets that don't map to whole devices Christoph Hellwig
2017-02-04 17:20 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=420daead-8b81-c9ad-87cf-7d2e9ab2fc11@kernel.dk \
--to=axboe@kernel.dk \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox