From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7257148FF3 for ; Fri, 4 Oct 2024 10:53:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728039213; cv=none; b=GMDRwS1Sg37DcxwTFrPKiOo9ZCD+G9K3xTQdppSvlWo7/sqgwNK2+rGtH3mWXI7NHaOKt6LVreGtGtJq+ZsVgpXRWSe/Ty0g7DByGdzmrgK5qy3ygZBaEewrvFDv297YzcYPd/0ZAG7eTRSYQ3Lur0CtByMBuhWjHihP2kn8vQY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728039213; c=relaxed/simple; bh=PzKdKo+6viG8ybT5p4aenEuVziOs5E1Eia4x/Wj74Vo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PqlHQ1bvXi5uLCDrg4Bs/zqCadEz7kSNZGhbr/d1NU8IGjkztmCTtmSu+zVg4WkSQl4zG6TJDGfNPn/6ypxG+em7aEpN7CIOGncX/n4jEDegrgzmB87ZRKMeR0O+egWT+iDWjVFbOv4sJod4EFsRh6Mq9TRU6A33cEaK20K0tRE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=y2R7lRzx; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y2R7lRzx" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-37cc84c12c2so1101657f8f.3 for ; Fri, 04 Oct 2024 03:53:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728039209; x=1728644009; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ABWVEZnDfVLeVPAj/zUum6wdsVi6WG7u6OOY9X43WV4=; b=y2R7lRzxr8Pw023GiX61Nv6KGlyPVEFGabjNDBVcVXNC1KuY4y0UUXdoeG95g8TpKm 0N/x3T37m5409q5ympbbfaADRHtgmgKbbEDR8CuDR/EBU1ScoyHnxif2PquzmMdcGCdP sqTCRh1np/KXb3MmWkNUlFpPlT+gHZLtzojKIccD2CynlurUXDJGAmOGl5XCnYpfFYG7 uTNXrORyx3k4azi2rkpy2m26j1u2Tg5s63URCbFINfeKKCKcZrGvquRIFEVRKajPyN0N yf/itP2XmoWDI1jdylicpkkpJROT4IwQtOTpM6m5+xjow4KPbCfr6bkN0Ig8PL11lfeB Bx+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728039209; x=1728644009; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ABWVEZnDfVLeVPAj/zUum6wdsVi6WG7u6OOY9X43WV4=; b=QVKA1SqS9igkF6R0oDfWtN0xwUgwE1e16uXtVo6ppl5dRndTZ3XC7Io/aNmO0kzNzP XlztVSA/MuTwRXMqcd8LlT0pFabFFtwA5PMbSMc0seGre2IPBGqX8RGatPNws7qwI5lF hWatmLvyStIMC1gcUwY66R0DS8ROFwy6CYQwZriZ9iKfik4VuPV76883HG7UtXxlS5Bj vK0XribR4u7kW5SVP55gaw2lMTVYLj6PRoUkRXseweSPQaNDLKe+zeCFy+vOyQYvOVbD RNpj5Y6arKoqzV7aPOnnLRzq4lWM6RHTjv+6jDc2O/9a0a18dFdF+hImpIn3BgMsSl3V ixJw== X-Forwarded-Encrypted: i=1; AJvYcCWqeoqTimX2aE9ITb8hR/Al0ZdcDmbc4eZP+ClC8W/juQ1B2O73LKC0DuJo1wLEXD/rfyfE1znATU401g==@vger.kernel.org X-Gm-Message-State: AOJu0YzoQ5CXkWhPbjv+zl9URPhhm+R0bxp6J2raba6Z7gcw9y2RV8F1 eZPgxn9u/1CPLBlR6XsJ567ItEd9xpECK1m0BbTId2qtJEgKhuvnk/O1vxyyHko= X-Google-Smtp-Source: AGHT+IEkdLbehk6VGRk0CI7zwvonPN6LVZnevW4vIzHsEFitfQTuqEF+iuYKEYiJ2wMybm3F0oINLA== X-Received: by 2002:adf:ce8f:0:b0:371:8a3a:680a with SMTP id ffacd0b85a97d-37d0e782737mr1354874f8f.32.1728039209176; Fri, 04 Oct 2024 03:53:29 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d0826240csm2993941f8f.65.2024.10.04.03.53.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 03:53:28 -0700 (PDT) Date: Fri, 4 Oct 2024 13:53:15 +0300 From: Dan Carpenter To: Tejun Heo Cc: Jens Axboe , Waiman Long , Yu Kuai , Josef Bacik , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v2] blk_iocost: remove some duplicate irq disable/enables Message-ID: <43245907-0b08-4e18-b58c-a36ab0f804de@stanley.mountain> References: <0a8fe25b-9b72-496d-b1fc-e8f773151e0a@redhat.com> <925f3337-cf9b-4dc1-87ea-f1e63168fbc4@stanley.mountain> <3083c357-9684-45d3-a9c7-2cd2912275a1@stanley.mountain> <68f3e5f8-895e-416b-88cf-284a263bd954@stanley.mountain> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Oct 03, 2024 at 11:30:44AM -1000, Tejun Heo wrote: > On Thu, Oct 03, 2024 at 11:22:09AM -1000, Tejun Heo wrote: > > Yeah, that should be spin_lock_irq() for consistency but at the same time it > > doesn't look like anything is actually grabbing that lock (or blkcg->lock > > nesting outside of it) from an IRQ context, so no actual deadlock scenario > > exists and lockdep doesn't trigger. > > Oh, wait, it's not that. blkg_conf_prep() implies queue_lock, so the IRQ is > disabled around it and adding _irq will trigger lockdep. > Ugh... Yeah. Sorry for the noise on this. I've fixed my checker to not print this warning any more. regards, dan carpenter