From: Jens Axboe <axboe@kernel.dk>
To: "jianchao.wang" <jianchao.w.wang@oracle.com>
Cc: ming.lei@redhat.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V8 0/3] blk-mq: refactor code of issue request directly
Date: Tue, 4 Dec 2018 20:07:13 -0700 [thread overview]
Message-ID: <4383ef8a-4418-e341-d36d-bcbc0557c4a9@kernel.dk> (raw)
In-Reply-To: <154edba0-f4dc-716f-df64-50b23db39138@oracle.com>
On 12/4/18 8:01 PM, jianchao.wang wrote:
>
>
> On 12/5/18 10:58 AM, Jens Axboe wrote:
>> On 11/14/18 8:12 PM, Jianchao Wang wrote:
>>> Hi Jens
>>>
>>> Please consider this patchset for 4.21.
>>> It refactors the code of issue request directly to unify the interface
>>> and make the code clearer and more readable.
>>>
>>> The 1st patch refactors the code of issue request directly to unify the
>>> helper interface which could handle all the cases.
>>>
>>> The 2nd patch make blk_mq_sched_insert_requests issue requests directly
>>> with 'bypass' false, then it needn't to handle the non-issued requests
>>> any more.
>>>
>>> The 3rd patch replace and kill the blk_mq_request_issue_directly.
>>
>> I'd love to get this queued up, the direct dispatch path is a mess and
>> it's even now been known to cause corruptions... I'm going to queue
>> up the direct dispatch fix shortly, and apply it to for-4.21/block
>> as well. Any chance you can respin this on top after that?
>>
>
> OK, I will do now.
Thanks!
--
Jens Axboe
prev parent reply other threads:[~2018-12-05 3:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 3:12 [PATCH V8 0/3] blk-mq: refactor code of issue request directly Jianchao Wang
2018-11-15 3:12 ` [PATCH V8 1/3] blk-mq: refactor the " Jianchao Wang
2018-11-15 3:12 ` [PATCH V8 2/3] blk-mq: issue directly with bypass 'false' in blk_mq_sched_insert_requests Jianchao Wang
2018-11-15 3:12 ` [PATCH V8 3/3] blk-mq: replace and kill blk_mq_request_issue_directly Jianchao Wang
2018-12-05 2:58 ` [PATCH V8 0/3] blk-mq: refactor code of issue request directly Jens Axboe
2018-12-05 3:01 ` jianchao.wang
2018-12-05 3:07 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4383ef8a-4418-e341-d36d-bcbc0557c4a9@kernel.dk \
--to=axboe@kernel.dk \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).