From: Nilay Shroff <nilay@linux.ibm.com>
To: John Garry <john.g.garry@oracle.com>, axboe@kernel.dk
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 0/3] block stacked devices atomic writes fixes and improvement
Date: Wed, 17 Sep 2025 15:59:11 +0530 [thread overview]
Message-ID: <442d0ed5-22d9-4eb8-940b-428636b49a8d@linux.ibm.com> (raw)
In-Reply-To: <20250915103500.3335748-1-john.g.garry@oracle.com>
On 9/15/25 4:04 PM, John Garry wrote:
> This series contains a couple of fixes and a small improvement for
> supporting atomic writes on stacked devices.
>
> To catch any other issues, I have sent a separate series to improve
> blktests testing for the same in https://lore.kernel.org/linux-block/20250912095729.2281934-1-john.g.garry@oracle.com/
>
> Based on 7935b843ce218 (block/for-6.18/block) md/md-llbitmap: Use DIV_ROUND_UP_SECTOR_T
>
> John Garry (3):
> block: update validation of atomic writes boundary for stacked devices
> block: fix stacking of atomic writes when atomics are not supported
> block: relax atomic write boundary vs chunk size check
>
> block/blk-settings.c | 81 ++++++++++++++++++++------------------------
> 1 file changed, 37 insertions(+), 44 deletions(-)
>
Changes look good to me. I have also tested it against my NVMe disk supporting
atomic writes, and all seems good, so:
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
Tested-by: Nilay Shroff <nilay@linux.ibm.com>
prev parent reply other threads:[~2025-09-17 10:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 10:34 [PATCH 0/3] block stacked devices atomic writes fixes and improvement John Garry
2025-09-15 10:34 ` [PATCH 1/3] block: update validation of atomic writes boundary for stacked devices John Garry
2025-09-15 10:34 ` [PATCH 2/3] block: fix stacking of atomic writes when atomics are not supported John Garry
2025-09-15 10:35 ` [PATCH 3/3] block: relax atomic write boundary vs chunk size check John Garry
2025-09-16 18:25 ` [PATCH 0/3] block stacked devices atomic writes fixes and improvement Martin K. Petersen
2025-09-16 18:30 ` Jens Axboe
2025-09-17 10:29 ` Nilay Shroff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442d0ed5-22d9-4eb8-940b-428636b49a8d@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox