From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-scsi-owner@vger.kernel.org>
Subject: Re: [PATCH 15/16] block: split scsi_request out of struct request
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@fb.com>
References: <1485185361-29786-1-git-send-email-hch@lst.de>
 <1485185361-29786-16-git-send-email-hch@lst.de>
CC: Mike Snitzer <snitzer@redhat.com>, <linux-block@vger.kernel.org>,
        <linux-scsi@vger.kernel.org>, <dm-devel@redhat.com>
From: Bart Van Assche <bart.vanassche@sandisk.com>
Message-ID: <455a58ef-905c-abf9-ae59-ca98f003f31e@sandisk.com>
Date: Thu, 26 Jan 2017 11:12:51 -0800
MIME-Version: 1.0
In-Reply-To: <1485185361-29786-16-git-send-email-hch@lst.de>
Content-Type: text/plain; charset="windows-1252"
Sender: linux-scsi-owner@vger.kernel.org
List-ID: <linux-block@vger.kernel.org>

On 01/23/2017 07:29 AM, Christoph Hellwig wrote:
> +int scsi_cmd_buf_len(struct request *rq)
> +{
> +	return scsi_req(rq)->cmd_len * 3;
> +}
> +EXPORT_SYMBOL(scsi_cmd_buf_len);

Hello Christoph,

Where does the '* 3' come from? I think that deserves a comment.
Additionally, this patch introduces a new warning when building with W=1:

block/scsi_ioctl.c:761:5: warning: no previous prototype for
�scsi_cmd_buf_len� [-Wmissing-prototypes]

Please consider adding #include <linux/blktrace_api.h> to the source
file in which scsi_cmd_buf_len() is added.

Thanks,

Bart.