From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Cc: Saurav Kashyap <skashyap@marvell.com>
Subject: Re: [PATCH] block: bio-integrity: Copy flags when bio_integrity_payload is cloned
Date: Wed, 15 Feb 2023 21:20:44 +0000 [thread overview]
Message-ID: <45b9231f-442d-b1e5-6c80-e8725beaf62d@nvidia.com> (raw)
In-Reply-To: <20230215171801.21062-1-martin.petersen@oracle.com>
On 2/15/23 09:18, Martin K. Petersen wrote:
> Make sure to copy the flags when a bio_integrity_payload is cloned.
> Otherwise per-I/O properties such as IP checksum flag will not be
> passed down to the HBA driver. Since the integrity buffer is owned by
> the original bio, the BIP_BLOCK_INTEGRITY flag needs to be masked off
> to avoid a double free in the completion path.
>
> Fixes: aae7df50190a ("block: Integrity checksum flag")
> Fixes: b1f01388574c ("block: Relocate bio integrity flags")
> Reported-by: Saurav Kashyap <skashyap@marvell.com>
> Tested-by: Saurav Kashyap <skashyap@marvell.com>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2023-02-15 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 17:18 [PATCH] block: bio-integrity: Copy flags when bio_integrity_payload is cloned Martin K. Petersen
2023-02-15 21:20 ` Chaitanya Kulkarni [this message]
2023-02-16 6:05 ` Christoph Hellwig
2023-02-16 18:05 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45b9231f-442d-b1e5-6c80-e8725beaf62d@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=skashyap@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox