From: "Holger Hoffstätte" <holger@applied-asynchrony.com>
To: Paolo Valente <paolo.valente@linaro.org>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
ulf.hansson@linaro.org, linus.walleij@linaro.org,
broonie@kernel.org, bfq-iosched@googlegroups.com,
oleksandr@natalenko.name, fra.fra.800@gmail.com
Subject: Re: [PATCH BUGFIX IMPROVEMENT 0/8] block, bfq: fix bugs, reduce exec time and boost performance
Date: Thu, 7 Mar 2019 19:29:16 +0100 [thread overview]
Message-ID: <469708ba-e483-b98c-118d-abc26ab8871a@applied-asynchrony.com> (raw)
In-Reply-To: <20190307162554.77205-1-paolo.valente@linaro.org>
On 3/7/19 5:25 PM, Paolo Valente wrote:
> Hi,
> since I didn't make it to submit these ones for 5.1, let me be
> early for 5.2 :)
>
> These patches fix some bug affecting performance, reduce execution
> time a little bit, and boost throughput and responsiveness.
>
> They are meant to be applied on top of the last series I submitted:
> https://lkml.org/lkml/2019/1/29/368
I have the earlier series applied & working well. This one applies cleanly
on top, but something's wrong with the bfq_log_bfqq() macro:
CC [M] block/bfq-iosched.o
In file included from block/bfq-iosched.c:140:
block/bfq-iosched.c: In function 'bfq_check_fifo':
block/bfq-iosched.h:1058:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
char pid_str[MAX_PID_STR_LENGTH]; \
^~~~
block/bfq-iosched.c:890:2: note: in expansion of macro 'bfq_log_bfqq'
bfq_log_bfqq(bfqq->bfqd, bfqq, "check_fifo: returned %p", rq);
^~~~~~~~~~~~
block/bfq-iosched.c: In function 'bfq_updated_next_req':
block/bfq-iosched.h:1058:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
This is with gcc 8.3.0 on top of 5.0++.
thanks,
Holger
next prev parent reply other threads:[~2019-03-07 18:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 16:25 [PATCH BUGFIX IMPROVEMENT 0/8] block, bfq: fix bugs, reduce exec time and boost performance Paolo Valente
2019-03-07 16:25 ` [PATCH BUGFIX IMPROVEMENT 1/8] block, bfq: increase idling for weight-raised queues Paolo Valente
2019-03-07 16:25 ` [PATCH BUGFIX IMPROVEMENT 2/8] block, bfq: do not idle for lowest-weight queues Paolo Valente
2019-03-07 16:25 ` [PATCH BUGFIX IMPROVEMENT 3/8] block, bfq: tune service injection basing on request service times Paolo Valente
2019-03-07 16:25 ` [PATCH BUGFIX IMPROVEMENT 4/8] block, bfq: do not merge queues on flash storage with queueing Paolo Valente
2019-03-07 16:25 ` [PATCH BUGFIX IMPROVEMENT 5/8] block, bfq: do not tag totally seeky queues as soft rt Paolo Valente
2019-03-07 16:25 ` [PATCH BUGFIX IMPROVEMENT 6/8] block, bfq: always protect newly-created queues from existing active queues Paolo Valente
2019-03-07 16:25 ` [PATCH BUGFIX IMPROVEMENT 7/8] block, bfq: print SHARED instead of pid for shared queues in logs Paolo Valente
2019-03-07 16:25 ` [PATCH BUGFIX IMPROVEMENT 8/8] block, bfq: save & resume weight on a queue merge/split Paolo Valente
2019-03-07 18:29 ` Holger Hoffstätte [this message]
2019-03-07 22:04 ` [PATCH BUGFIX IMPROVEMENT 0/8] block, bfq: fix bugs, reduce exec time and boost performance Oleksandr Natalenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469708ba-e483-b98c-118d-abc26ab8871a@applied-asynchrony.com \
--to=holger@applied-asynchrony.com \
--cc=axboe@kernel.dk \
--cc=bfq-iosched@googlegroups.com \
--cc=broonie@kernel.org \
--cc=fra.fra.800@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr@natalenko.name \
--cc=paolo.valente@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox