public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: zhang <zhangweize9@gmail.com>
To: ming.lei@redhat.com
Cc: axboe@kernel.dk, csander@purestorage.com,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, shuah@kernel.org,
	ushankar@purestorage.com
Subject: Re: [PATCH 1/2] ublk: reset per-IO canceled flag on each fetch
Date: Sun, 5 Apr 2026 09:02:30 +0800	[thread overview]
Message-ID: <46c04059-03a0-4488-a4a5-4bb93aa46a1e@gmail.com> (raw)
In-Reply-To: <adER-jg0JfkE4I8n@fedora>

Dear Ming Lei:

I just looked at your solution, which is to reset immediately after each IO is claimed. This solution can indeed effectively solve the blocking problem. However, if there is a task that is repeated and exactly the same, then the process may run repeatedly many times. Do you think we should add some logic to handle repeated tasks?

Reviewed-by: zhang, the-essence-of-life.

-- 

the-essence-of-life

  reply	other threads:[~2026-04-05  1:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-04  3:23 [PATCH 0/2] ublk: fix infinite loop in ublk server teardown Uday Shankar
2026-04-04  3:23 ` [PATCH 1/2] ublk: reset per-IO canceled flag on each fetch Uday Shankar
2026-04-04 13:28   ` Ming Lei
2026-04-05  1:02     ` zhang [this message]
2026-04-06  3:16       ` Ming Lei
2026-04-06  3:37         ` zhang
2026-04-04  3:23 ` [PATCH 2/2] selftests: ublk: test that teardown after incomplete recovery completes Uday Shankar
2026-04-04 13:33   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46c04059-03a0-4488-a4a5-4bb93aa46a1e@gmail.com \
    --to=zhangweize9@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=csander@purestorage.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=shuah@kernel.org \
    --cc=ushankar@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox