From: Phillip Lougher <phillip@squashfs.org.uk>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
willy@infradead.org, axboe@kernel.dk,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH 1/2] block: Rework bio_for_each_segment_all()
Date: Thu, 30 Mar 2023 19:59:46 +0100 [thread overview]
Message-ID: <4753802a-685f-ab56-fed2-22d6eb4cfccd@squashfs.org.uk> (raw)
In-Reply-To: <ZCXNDQ6Eslhj+9g5@moria.home.lan>
On 30/03/2023 18:55, Kent Overstreet wrote:
> On Wed, Mar 29, 2023 at 05:50:27PM +0100, Phillip Lougher wrote:
>> There is a problem with the above code, on testing I get the following
>> results:
>>
>> Index 78018785329, offset 49, bvec.bv_len 1024: In same bio, metadata length
>> 32780
>
> Could you share how you're doing your testing? I set up a basic test
> (created images using every compression type, tested reading them) and
> so far I'm not able to reproduce this.
I use a very large Squashfs file that triggers the edge case.
That is too big to post, and so I'll see if I can artifically generate
a small Squashfs filesystem that triggers the edge case.
Phillip
next prev parent reply other threads:[~2023-03-30 19:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 17:44 [PATCH 0/2] bio iter improvements Kent Overstreet
2023-03-27 17:44 ` [PATCH 1/2] block: Rework bio_for_each_segment_all() Kent Overstreet
2023-03-29 16:50 ` Phillip Lougher
2023-03-30 17:55 ` Kent Overstreet
2023-03-30 18:59 ` Phillip Lougher [this message]
2023-03-31 1:10 ` Phillip Lougher
2023-04-01 2:28 ` Kent Overstreet
2023-04-03 13:57 ` Phillip Lougher
2023-03-30 11:49 ` Ming Lei
2023-03-30 16:20 ` Kent Overstreet
2023-03-27 17:44 ` [PATCH 2/2] block: Rework bio_for_each_folio_all() Kent Overstreet
2023-04-03 15:13 ` Christoph Hellwig
2023-04-03 15:51 ` Kent Overstreet
2023-03-27 22:14 ` [PATCH 0/2] bio iter improvements Christoph Hellwig
2023-03-28 20:28 ` Kent Overstreet
2023-04-03 15:10 ` Christoph Hellwig
2023-04-03 16:36 ` Kent Overstreet
2023-04-04 15:20 ` Christoph Hellwig
2023-04-04 15:47 ` Kent Overstreet
2023-04-04 15:59 ` Christoph Hellwig
2023-04-04 16:08 ` Kent Overstreet
2023-04-04 16:01 ` Jens Axboe
2023-04-04 16:06 ` Kent Overstreet
2023-04-04 16:14 ` Jens Axboe
2023-04-04 17:11 ` Kent Overstreet
2023-03-28 13:42 ` Phillip Lougher
2023-03-28 16:57 ` Kent Overstreet
2023-03-29 16:41 ` Phillip Lougher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4753802a-685f-ab56-fed2-22d6eb4cfccd@squashfs.org.uk \
--to=phillip@squashfs.org.uk \
--cc=axboe@kernel.dk \
--cc=kent.overstreet@linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox