From: Damien Le Moal <dlemoal@kernel.org>
To: Zhaoyang Huang <huangzhaoyang@gmail.com>,
Niklas Cassel <Niklas.Cassel@wdc.com>
Cc: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"steve.kang@unisoc.com" <steve.kang@unisoc.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH 1/1] block: print warning when invalid domain set to ioprio
Date: Thu, 1 Feb 2024 08:59:36 +0900 [thread overview]
Message-ID: <487ac3ad-2343-451b-a84e-153d0b01dee4@kernel.org> (raw)
In-Reply-To: <CAGWkznGOjsA3eGRt4i-1XAt=39ce7vaN7=zciimLJOMg=HD7Zw@mail.gmail.com>
On 2/1/24 08:34, Zhaoyang Huang wrote:
> On Wed, Jan 31, 2024 at 9:07 PM Niklas Cassel <Niklas.Cassel@wdc.com> wrote:
>> This sound like either a bug in the FS or by some of your local changes
>> that you did for your other patch (ioprio based on activity).
> Yes. That's why I would like to suggest adding some information here
> to help developers find the clue quickly.
The backtrace was not clear enough ?
When a request reaches mq-deadline, the request priority is supposed to be
correct already. Your changes had a bug and broke that assumption. Please fix
that instead of adding error messages for errors that should never happen in the
first place.
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2024-01-31 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240131121401.3898735-1-zhaoyang.huang@unisoc.com>
2024-01-31 12:52 ` [PATCH 1/1] block: print warning when invalid domain set to ioprio Niklas Cassel
2024-01-31 13:07 ` Niklas Cassel
2024-01-31 23:34 ` Zhaoyang Huang
2024-01-31 23:59 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487ac3ad-2343-451b-a84e-153d0b01dee4@kernel.org \
--to=dlemoal@kernel.org \
--cc=Niklas.Cassel@wdc.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=huangzhaoyang@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=steve.kang@unisoc.com \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox