Linux block layer
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Zizhi Wo <wozizhi@huaweicloud.com>,
	axboe@kernel.dk, dlemoal@kernel.org, nilay@linux.ibm.com,
	linux-block@vger.kernel.org, kch@nvidia.com,
	johannes.thumshirn@wdc.com, kbusch@kernel.org
Cc: linux-kernel@vger.kernel.org, yangerkun@huawei.com,
	chengzhihao1@huawei.com, wozizhi@huawei.com
Subject: Re: [PATCH 3/3] null_blk: register configfs subsystem after creating default devices
Date: Mon, 6 Jul 2026 06:17:43 -0700	[thread overview]
Message-ID: <490008e2-2345-48ea-bd8e-c078d828a43f@acm.org> (raw)
In-Reply-To: <20260706123507.3809871-4-wozizhi@huaweicloud.com>

On 7/6/26 5:35 AM, Zizhi Wo wrote:
> @@ -2187,8 +2185,6 @@ static int __init null_init(void)
>   		null_destroy_dev(nullb);
>   	}
>   	unregister_blkdev(null_major, "nullb");
> -err_conf:
> -	configfs_unregister_subsystem(&nullb_subsys);
>   	return ret;
>   }

Please make null_exit() consistent with the cleanup path in null_init().
null_exit() calls unregister_blkdev() before it destroys the null_blk
instances. That doesn't look right to me.

Thanks,

Bart.




  reply	other threads:[~2026-07-06 13:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 12:35 [PATCH 0/3] null_blk: fix mutex initialization and configfs teardown race Zizhi Wo
2026-07-06 12:35 ` [PATCH 1/3] null_blk: use DEFINE_MUTEX for the file-scope mutex Zizhi Wo
2026-07-06 13:13   ` Bart Van Assche
2026-07-06 12:35 ` [PATCH 2/3] null_blk: give the file-scope mutex a descriptive name Zizhi Wo
2026-07-06 13:12   ` Bart Van Assche
2026-07-06 13:21     ` Zizhi Wo
2026-07-06 14:45       ` Bart Van Assche
2026-07-06 12:35 ` [PATCH 3/3] null_blk: register configfs subsystem after creating default devices Zizhi Wo
2026-07-06 13:17   ` Bart Van Assche [this message]
2026-07-06 13:34     ` Zizhi Wo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=490008e2-2345-48ea-bd8e-c078d828a43f@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=chengzhihao1@huawei.com \
    --cc=dlemoal@kernel.org \
    --cc=johannes.thumshirn@wdc.com \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nilay@linux.ibm.com \
    --cc=wozizhi@huawei.com \
    --cc=wozizhi@huaweicloud.com \
    --cc=yangerkun@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox