From: Jens Axboe <axboe@kernel.dk>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Alex Ivanov <yourbestfriend@openmailbox.org>,
linux-block@vger.kernel.org
Subject: Re: [PATCH] elevator: allow specifying elevator by config boot param for blk-mq devices
Date: Thu, 13 Jul 2017 08:02:41 -0600 [thread overview]
Message-ID: <49033d7d-8941-3c17-962f-dab170401bcf@kernel.dk> (raw)
In-Reply-To: <20170713101154.GH5212@linux-x5ow.site>
On 07/13/2017 04:11 AM, Johannes Thumshirn wrote:
> On Wed, Jul 12, 2017 at 04:51:33PM -0600, Jens Axboe wrote:
>> No, that boot option was a mistake, let's not propagate that to mq
>> scheduling as well.
>
> Can you please explain why? I as well have requests from our users to
> select the mq schedulers on the command line.
Because it sucks as an interface - there's no way to apply different
settings to different devices, and using the kernel command line to
control something like this is ugly. It never should have been done.
The sysfs interface, either manually, scripted, or through udev,
makes a lot more sense.
--
Jens Axboe
next prev parent reply other threads:[~2017-07-13 14:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 18:57 [PATCH] elevator: allow specifying elevator by config boot param for blk-mq devices Alex Ivanov
2017-07-12 22:51 ` Jens Axboe
2017-07-13 10:11 ` Johannes Thumshirn
2017-07-13 14:02 ` Jens Axboe [this message]
2017-07-14 5:12 ` Paolo Valente
2017-07-14 6:40 ` Johannes Thumshirn
2017-07-14 14:26 ` Jens Axboe
2017-07-17 6:55 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49033d7d-8941-3c17-962f-dab170401bcf@kernel.dk \
--to=axboe@kernel.dk \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=yourbestfriend@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox