From: John Garry <john.g.garry@oracle.com>
To: Jens Axboe <axboe@kernel.dk>, Salah Triki <salah.triki@gmail.com>,
"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
Jack Wang <jinpu.wang@ionos.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: rnbd: add .release to rnbd_dev_ktype
Date: Mon, 28 Apr 2025 09:24:14 +0100 [thread overview]
Message-ID: <492ab2dc-d062-4dc5-8d48-4e357ea4adbf@oracle.com> (raw)
In-Reply-To: <fb3add67-c469-483e-ac51-e53dea7df360@kernel.dk>
On 27/04/2025 23:03, Jens Axboe wrote:
> On 4/27/25 9:48 AM, Salah Triki wrote:
>> Every ktype must provides a .release function that will be called after
>> the last kobject_put.
You could mention Documentation/core-api/kobject.rst?h=v6.15-rc3#n279,
which tells us this. As does the check in kobject_cleanup().
>
> This commit needs:
>
> 1) A description of the problem. There's just a vague statement in
> there.
> 2) A Fixes tag
>
next prev parent reply other threads:[~2025-04-28 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-27 15:48 [PATCH] block: rnbd: add .release to rnbd_dev_ktype Salah Triki
2025-04-27 22:03 ` Jens Axboe
2025-04-28 8:24 ` John Garry [this message]
2025-04-28 9:58 ` Jinpu Wang
2025-05-04 17:20 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492ab2dc-d062-4dc5-8d48-4e357ea4adbf@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=haris.iqbal@ionos.com \
--cc=jinpu.wang@ionos.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox