From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F40981D95A3; Mon, 18 Nov 2024 18:07:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731953249; cv=none; b=PIofbW5CZnw/CJoLL9XdLRfeytph4cTfbV7sPy4DH+Hh+YYxJbRRgjC06aw30MmQoAzk1/aOmWLrBUZ1s63VOVt8Ej0yAqbp19t239ZATNsTvoXCmFHUieUpwXDDvTGhb9Xa0VS/8EG2WZZ7yOPsW9SLadraqeEaI19eb6qEqcs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731953249; c=relaxed/simple; bh=I8/ZSP3TbGLzfnlA4nKLHy+XyARP+KJTYkdkSH9CGew=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=LW+oX7kdsdsnwJV6bMmkIXn/6OX1o7kxOhVWSkU/+57ASZuj8D+2Csj2hx9Xzi7jbg8HWWSS2mLoxwdXG/V8qAPkONix8TMXdNLDWANmuwX1CHstaFb2CpMvsHTHSSDdwDVFP+u7HLW774r3lj9MyVVtcgwIWOtCSTCsRH3rTuw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=U8YJ5MEB; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="U8YJ5MEB" Received: from [192.168.35.166] (c-73-118-245-227.hsd1.wa.comcast.net [73.118.245.227]) by linux.microsoft.com (Postfix) with ESMTPSA id 3DD17206BCF9; Mon, 18 Nov 2024 10:07:25 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3DD17206BCF9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1731953247; bh=lP0Zntp+HRWENCbPjrc9G2lDoefH/1cMkwirwj5j8Pw=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=U8YJ5MEB+lC4gUMBqZ4Gz30eL5pByQSSZkvP1DxkMnTP1qlIes9QjQ3oHvl0/spjY zaV4G+9kqg2wB6l6cY05sRrhV/1+2NwT0Di3E3r4OqgFDSinGSRYQd2YjZAhmOdf7k pgtoi2CJWleSz5F2PF0YMgIK9D4gDdAFvwZB2ktQ= Message-ID: <4a3e6cfe-35ef-4865-8b43-c002679455f3@linux.microsoft.com> Date: Mon, 18 Nov 2024 10:07:24 -0800 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Madhavan Srinivasan , eahariha@linux.microsoft.com, "netfilter-devel@vger.kernel.org" , "coreteam@netfilter.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "cocci@inria.fr" , "linux-arm-kernel@lists.infradead.org" , "linux-s390@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "intel-xe@lists.freedesktop.org" , "linux-scsi@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "linux-block@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "ath11k@lists.infradead.org" , "linux-mm@kvack.org" , "linux-bluetooth@vger.kernel.org" , "linux-staging@lists.linux.dev" , "linux-rpi-kernel@lists.infradead.org" , "ceph-devel@vger.kernel.org" , "live-patching@vger.kernel.org" , "linux-sound@vger.kernel.org" , "etnaviv@lists.freedesktop.org" , "oss-drivers@corigine.com" , "linuxppc-dev@lists.ozlabs.org" , Anna-Maria Behnsen Subject: Re: [PATCH v2 00/21] Converge on using secs_to_jiffies() To: LEROY Christophe References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> From: Easwar Hariharan Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/16/2024 2:23 AM, LEROY Christophe wrote: > > > Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : >> [Vous ne recevez pas souvent de courriers de eahariha@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] >> >> This is a series that follows up on my previous series to introduce >> secs_to_jiffies() and convert a few initial users.[1] In the review for >> that series, Anna-Maria requested converting other users with >> Coccinelle. This is part 1 that converts users of msecs_to_jiffies() >> that use the multiply pattern of either of: >> - msecs_to_jiffies(N*1000), or >> - msecs_to_jiffies(N*MSEC_PER_SEC) > > After applying this series on top of tip/timers/core tree, I still find > a lot of candidates to the conversion: > Thanks for looking, that pattern of seconds-denominated msecs_to_jiffies() calls will be addressed in a later part. As mentioned in my reply to Anna-Maria[1], I'm not super-familiar with Coccinelle. I sent this out as part 1 as mentioned in the cover letter above to make incremental progress as much as I could. Julia has sent me a message with a rule that could possibly address the pattern you point out. I also see there are some instances in the grep results that appear to be expression * 1000 rather than constant * 1000. I'll address those in one of the later parts as well. Thanks, Easwar