From: Kashyap Desai <kashyap.desai@broadcom.com>
To: "jianchao.wang" <jianchao.w.wang@oracle.com>,
Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org,
Laurence Oberman <loberman@redhat.com>,
Omar Sandoval <osandov@fb.com>, Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bart.vanassche@wdc.com>,
Hannes Reinecke <hare@suse.de>
Subject: RE: [PATCH 0/3] blk-mq: improve IO perf in case of none io sched
Date: Thu, 28 Jun 2018 12:05:09 +0530 [thread overview]
Message-ID: <4a646f076f03e328fadc648931fd297b@mail.gmail.com> (raw)
In-Reply-To: <6683279e-7703-f8d3-bf97-67edcd6f2680@oracle.com>
>
> I guess we need to clean list after list_splice_tail in the 1/1 patch as
> following
> @@ -1533,19 +1533,19 @@ void blk_mq_insert_requests(struct
> blk_mq_hw_ctx *hctx, struct blk_mq_ctx *ctx,
> struct list_head *list)
>
> {
> ...
> +
> + spin_lock(&ctx->lock);
> + list_splice_tail(list, &ctx->rq_list);
> + INIT_LIST_HEAD(list); // ---> HERE !
I will try replacing " list_splice_tail" with " list_splice_tail_init"
Kashyap
> blk_mq_hctx_mark_pending(hctx, ctx);
> spin_unlock(&ctx->lock);
>
> Thanks
> Jianchao
next prev parent reply other threads:[~2018-06-28 6:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 3:19 [PATCH 0/3] blk-mq: improve IO perf in case of none io sched Ming Lei
2018-06-28 3:19 ` [PATCH 1/3] blk-mq: use list_splice_tail() to insert requests Ming Lei
2018-06-28 7:27 ` Johannes Thumshirn
2018-06-28 19:44 ` Jens Axboe
2018-06-28 19:52 ` Steven Rostedt
2018-06-28 19:58 ` Jens Axboe
2018-06-28 3:19 ` [PATCH 2/3] blk-mq: only attempt to merge bio if there is rq in sw queue Ming Lei
2018-06-28 3:19 ` [PATCH 3/3] blk-mq: dequeue request one by one from sw queue iff hctx is busy Ming Lei
2018-06-28 5:42 ` [PATCH 0/3] blk-mq: improve IO perf in case of none io sched Kashyap Desai
2018-06-28 6:03 ` jianchao.wang
2018-06-28 6:35 ` Kashyap Desai [this message]
2018-06-28 7:08 ` Ming Lei
2018-06-28 7:40 ` Kashyap Desai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a646f076f03e328fadc648931fd297b@mail.gmail.com \
--to=kashyap.desai@broadcom.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).